From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756474AbYKTTRc (ORCPT ); Thu, 20 Nov 2008 14:17:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754703AbYKTTRX (ORCPT ); Thu, 20 Nov 2008 14:17:23 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:37143 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754413AbYKTTRW (ORCPT ); Thu, 20 Nov 2008 14:17:22 -0500 Date: Thu, 20 Nov 2008 20:16:50 +0100 From: Ingo Molnar To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Andrew Morton , Paul Mackerras , Benjamin Herrenschmidt , Thomas Gleixner , linuxppc-dev@ozlabs.org, Milton Miller Subject: Re: [PATCH 0/5] powerpc: dynamic ftrace port Message-ID: <20081120191650.GD3955@elte.hu> References: <20081120190948.057007623@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081120190948.057007623@goodmis.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > Paul and Ingo, > > The following are the changes to get dynamic ftrace working on PowerPC. > I modified these a little from the last postings. > > 1) I removed the changes to recordmcount.pl. This is not a PowerPC > change, although PowerPC needs it for dynamic ftrace. But > the changes here can go via linux-tip. > > 2) I removed the adding of HAVE_DYNAMIC_FTRACE and HAVE_FTRACE_MCOUNT_RECORD. > Without these config options, this code will not be compiled. > I have a separate patch that adds them in when the time is right. > > Paul, these patches should not harm anything if you decide to pull them > in. As I stated above, without the above config options, they are > not enabled. > > There is one exception and that is for the first patch. The first patch > is actually a fix for the irqsoff latency tracer which is already > in mainline for PowerPC. > > These patches only touch PowerPC code. > > The following patches are in: > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git > > branch: ppc/ftrace > > > Steven Rostedt (5): > powerpc: ftrace, do not latency trace idle > powerpc: ftrace, convert to new dynamic ftrace arch API > powerpc: ftrace, use probe_kernel API to modify code > powerpc/ppc64: ftrace, handle module trampolines for dyn ftrace > powerpc/ppc32: ftrace, dynamic ftrace to handle modules > > ---- > arch/powerpc/include/asm/ftrace.h | 14 +- > arch/powerpc/include/asm/module.h | 16 ++- > arch/powerpc/kernel/ftrace.c | 473 +++++++++++++++++++++++++++++++++--- > arch/powerpc/kernel/idle.c | 5 + > arch/powerpc/kernel/module_32.c | 10 + > arch/powerpc/kernel/module_64.c | 13 + > 6 files changed, 489 insertions(+), 42 deletions(-) looks perfect to me! Thanks Steve for going through this - this was really a logistical worst-case-scenario. Now lets hope it looks good to Paul too and we can get his Acked-by :-) Ingo