From: Ingo Molnar <mingo@elte.hu>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
cpufreq@vger.kernel.org, stable@kernel.org, "Langsdorf,
Mark" <mark.langsdorf@amd.com>,
linux-kernel@vger.kernel.org, davej@redhat.com
Subject: Re: [PATCH] x86: powernow-k8: ignore out-of-range PstateStatus value
Date: Fri, 21 Nov 2008 16:12:52 +0100 [thread overview]
Message-ID: <20081121151252.GA17052@elte.hu> (raw)
In-Reply-To: <20081121131609.GA10975@alberich.amd.com>
* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
> On Fri, Nov 21, 2008 at 09:23:46AM +0100, Ingo Molnar wrote:
> >
> > nice fix! A few minor nits:
> >
> > > + /* a workaround for family 11h erratum 311 might cause
> > > + an "out-of-range Pstate if the core is in Pstate-0 */
>
> > Please use the customary comment style:
> > /*
> > * Comment .....
> > * ...... goes here:
> > */
>
> I don't prefer that style -- but if you do.
it's not about my or your preference. It's about what we all do in the
kernel, documented in Documentation/CodingStyle:
| The preferred style for long (multi-line) comments is:
|
| /*
| * This is the preferred style for multi-line
| * comments in the Linux kernel source code.
| * Please use it consistently.
| *
| * Description: A column of asterisks on the left side,
| * with beginning and ending almost-blank lines.
| */
Ingo
next prev parent reply other threads:[~2008-11-21 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 15:08 [PATCH] x86: powernow-k8: ignore out-of-range PstateStatus value Andreas Herrmann
2008-11-21 8:08 ` Andreas Herrmann
2008-11-21 8:23 ` Ingo Molnar
2008-11-21 13:16 ` Andreas Herrmann
2008-11-21 15:12 ` Ingo Molnar [this message]
2008-11-21 13:49 ` [PATCH v2] " Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081121151252.GA17052@elte.hu \
--to=mingo@elte.hu \
--cc=andreas.herrmann3@amd.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox