From: Jean Delvare <khali@linux-fr.org>
To: Chuck Ebbert <cebbert@redhat.com>, linux-kernel@vger.kernel.org
Cc: gregkh@suse.de, Jean Delvare <khali@linux-fr.org>,
Henrik Rydberg <rydberg@euromail.se>, Greg KH <greg@kroah.com>,
rkoktarianto@gmail.com, mhoffman@lightlink.com,
nicolas@boichat.ch, stable-commits@vger.kernel.org,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
stable@kernel.org
Subject: Re: [stable] patch hwmon-applesmc-add-support-for-macbook-air.patch added to 2.6.27-stable tree
Date: Sat, 22 Nov 2008 11:30:59 +0100 [thread overview]
Message-ID: <20081122113059.334d203c@hyperion.delvare> (raw)
In-Reply-To: <20081121163219.601e68be@redhat.com>
On Fri, 21 Nov 2008 16:32:19 -0500, Chuck Ebbert wrote:
> On Fri, 21 Nov 2008 11:01:42 -0800
> Greg KH <gregkh@suse.de> wrote:
>
> > On Thu, Nov 20, 2008 at 09:01:21AM +0100, Jean Delvare wrote:
> > > On Thu, 20 Nov 2008 02:07:17 +0100, Henrik Rydberg wrote:
> > > > Absolutely. However, since the commits are all in Linus' tree, cherry-picking
> > > > sounds like the easiest thing, does it not? Here are the commits to applesmc,
> > > > in reverse chronological order, since the 2.6.27 release:
> > > >
> > > > 468cc0320ed083e26364d9febde2679d981ed6a6 hwmon: applesmc: add support for Macbook 4
> > > > eefc488f96cdde6e152b45675b50bf380b95d99f hwmon: applesmc: add support for iMac 8
> > > > a66603257bf88bbe2c9fd6a97ee5dc24de15d196 hwmon: applesmc: add support for Macbook Pro 5
> > > > 181209a1d91756bfd83b1d6ce2008cea3ca225b6 hwmon: applesmc: add support for Macbook 5
> > > > 6e3530fa241ae759313496f67295c9252691ed04 hwmon: applesmc: add support for iMac 5
> > > > 8c9398d1e9766e3659e277acb2e8ca1c17684139 hwmon: applesmc: lighter wait mechanism, drastic improvement
> > > > 07e8dbd3ebbdedc71335049dd4b0d542cb038d7d hwmon: applesmc: Add support for Macbook Pro 3
> > > > d7549905f157f217b888edb0f2055f5090eaf1d8 hwmon: applesmc: Add support for Macbook Pro 4
> > > > 7b5e3cb28f52f42d8cf2b36771be580f33bbc7ae drivers/hwmon/applesmc.c: remove unneeded casts
> > > > f5274c972bac2d14c092a9c634e03f51785c7b76 hwmon: applesmc: add support for Macbook Air
> > > > 8bd1a12a51871f0c870612d8220b1485d6aefc73 hwmon: applesmc: allow for variable ALV0 and ALV1 package length
> > > > 02fcbd144d684167aa67b1d3ad68f18d265f2d08 hwmon: applesmc: prolong status wait
> > > > 84d2d7f2ee98dc9bd799790c89b5eb8280af2d37 hwmon: applesmc: fix the 'wait status failed: c != 8' problem
> > > > 05224091af06177c0ce7c1fae1f498455b47a6be hwmon: applesmc: specified number of bytes to read should match actual
> > > >
> > > > The non-trivial ones are 8c9398, 8bd1a1 and 84d2d7.
> > >
> > > This is too much for -stable IMHO.
> >
> > In looking at the non-trivial ones, I agree, it's not just a "simple"
> > addition, sorry.
>
> OTOH the driver is basically broken without all those patches.
Feel free to send a single patch disabling the driver altogether in
-stable if this is really the case.
--
Jean Delvare
prev parent reply other threads:[~2008-11-22 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081111184816.80D2D49036@coco.kroah.org>
[not found] ` <4919E869.2060302@euromail.se>
[not found] ` <20081111203341.GA29042@suse.de>
[not found] ` <4919EF97.1010900@euromail.se>
[not found] ` <20081111210121.GA29731@suse.de>
[not found] ` <49241411.6020807@euromail.se>
[not found] ` <20081119155436.GB4983@kroah.com>
[not found] ` <4924B845.9060705@euromail.se>
[not found] ` <20081120090121.08ee7b0c@hyperion.delvare>
[not found] ` <20081121190142.GC31017@suse.de>
2008-11-21 21:32 ` [stable] patch hwmon-applesmc-add-support-for-macbook-air.patch added to 2.6.27-stable tree Chuck Ebbert
2008-11-22 10:30 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081122113059.334d203c@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=cebbert@redhat.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mhoffman@lightlink.com \
--cc=nicolas@boichat.ch \
--cc=rkoktarianto@gmail.com \
--cc=rydberg@euromail.se \
--cc=stable-commits@vger.kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox