public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86: signal: cosmetic unification of sys_rt_sigreturn()
Date: Sun, 23 Nov 2008 10:51:46 +0100	[thread overview]
Message-ID: <20081123095146.GR30453@elte.hu> (raw)
In-Reply-To: <4927698C.90104@ct.jp.nec.com>


* Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:

> H. Peter Anvin wrote:
> > Hiroshi Shimamoto wrote:
> >>  
> >> +#ifdef CONFIG_X86_32
> >>  asmlinkage int sys_rt_sigreturn(unsigned long __unused)
> >>  {
> >>  	struct pt_regs *regs = (struct pt_regs *)&__unused;
> >>  
> >>  	return do_rt_sigreturn(regs);
> >>  }
> > 
> > Why not:
> > 
> > asmlinkage int sys_rt_sigreturn(struct pt_regs regs)
> > {
> > 	return do_rt_sigreturn(&regs);
> > }
> > 
> > ...?
> 
> Good question. I didn't realize about that.
> Will take a look.

I've applied your 3 patches to tip/x86/signal - please send a patch on 
top of your current lineup, for the detail Peter pointed out.

Thanks,

	Ingo

  reply	other threads:[~2008-11-23  9:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-22  1:36 [PATCH 1/3] x86: signal: cosmetic unification of including headers Hiroshi Shimamoto
2008-11-22  1:38 ` [PATCH 2/3] x86: signal: cosmetic unification of sys_sigaltstack() Hiroshi Shimamoto
2008-11-22  1:38 ` [PATCH 3/3] x86: signal: cosmetic unification of sys_rt_sigreturn() Hiroshi Shimamoto
2008-11-22  1:50   ` H. Peter Anvin
2008-11-22  2:08     ` Hiroshi Shimamoto
2008-11-23  9:51       ` Ingo Molnar [this message]
2008-11-24 23:55         ` Hiroshi Shimamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081123095146.GR30453@elte.hu \
    --to=mingo@elte.hu \
    --cc=h-shimamoto@ct.jp.nec.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox