From: Pavel Machek <pavel@suse.cz>
To: Theodore Tso <tytso@mit.edu>, "H. Peter Anvin" <hpa@zytor.com>,
Shem Multinymous <multinymous@gmail.com>,
"J.R. Mauro" <jrm8005@gmail.com>,
tpctl-users@lists.sourceforge.net, linux-kernel@vger.kernel.org,
Greg KH <greg@kroah.com>
Subject: Re: [Tpctl-users] Inclusion of tp_smapi module into kernel?
Date: Sun, 23 Nov 2008 13:30:32 +0100 [thread overview]
Message-ID: <20081123123032.GA7310@ucw.cz> (raw)
In-Reply-To: <20081117202704.GG14523@mit.edu>
On Mon 2008-11-17 15:27:04, Theodore Tso wrote:
> On Mon, Nov 17, 2008 at 11:21:09AM -0800, H. Peter Anvin wrote:
> >> We've discussed that in private at the time, and recently on LKML too.
> >> In summary:
> >> I'm fine with that, and so is everybody I talked to (including Linus),
> >> except Greg KH who vetoed it since he believes the code is irrevocably
> >> and contagiously evil.
> >>
> >
> > Signed-off-by is about copyright, it's not a review issue. It means "I
> > certify that I know that the author had the rights to submit this code."
> > Code quality is important but separate.
>
> Indeed; so what were Greg KH's complaints, specifically? Were they a
> code review issue or was just complaining about the anonymity issue?
Anonymity issue.
I'm working on similar driver for HP machines, and it would be great
to be able to test that on my thinkpad, so I'm willing to clean up
the code if required, maintain it, whatever...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-11-23 17:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 13:55 Inclusion of tp_smapi module into kernel? Hanno Böck
2008-11-17 16:38 ` H. Peter Anvin
2008-11-17 17:13 ` J.R. Mauro
2008-11-17 18:35 ` [Tpctl-users] " Shem Multinymous
2008-11-17 18:49 ` J.R. Mauro
2008-11-17 19:21 ` H. Peter Anvin
2008-11-17 20:27 ` Theodore Tso
2008-11-23 12:30 ` Pavel Machek [this message]
2008-11-17 20:35 ` Miklos Szeredi
2008-11-18 13:48 ` Henrique de Moraes Holschuh
2008-11-18 17:13 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081123123032.GA7310@ucw.cz \
--to=pavel@suse.cz \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=jrm8005@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=multinymous@gmail.com \
--cc=tpctl-users@lists.sourceforge.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox