From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Alexander van Heukelum <heukelum@mailshack.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] x86: introduce ENTRY(KPROBE)_X86 assembly helpers to catch unbalanced declaration
Date: Sun, 23 Nov 2008 20:58:46 +0300 [thread overview]
Message-ID: <20081123175846.GF12710@localhost> (raw)
In-Reply-To: <20081123175125.GA32472@uranus.ravnborg.org>
[Sam Ravnborg - Sun, Nov 23, 2008 at 06:51:25PM +0100]
| On Sun, Nov 23, 2008 at 07:57:11PM +0300, Cyrill Gorcunov wrote:
| > It's usefull to catch unbalanced, missed or mixed declarations of ENTRY and
| > KPROBES. These macros would help a bit (at least I hope so).
| >
| > For example the following code would compile without problems
| >
| > ENTRY_X86(mcount)
| > retq
| > END_X86(mcount)
| >
| > But if you forget and mix the following form
| >
| > ENTRY_X86(mcount)
| > retq
| > END(mcount)
| >
| > ENTRY_X86(ftrace_caller)
| >
| > The assembler will issue the following message:
| > Error: ENTRY_X86/KPROBE_X86 unbalanced,missed,mixed
| >
| > Actually the checking is performed at every _X86 macro
| > so maybe it's good idea to put ENTRY_KPROBE_FINAL_X86
| > at the end of .S file to be sure you didn't miss anything.
|
| Could we at least try this out in -next before we decide to make
| this X86 only?
| I am aware that binutils can be a bit fragile but -next testing should
| make a good check on this.
|
| Sam
|
I don't have -next tree on my laptop, neither cross-compile tools but
if someone could test it -- it would be great. But I used gas macros
here -- i doubt other architectures has the same syntax. At least
PDP-11 would beat us with ';' symbol :)
- Cyrill -
next prev parent reply other threads:[~2008-11-23 17:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 16:57 [RFC -tip] x86: introduce ENTRY(KPROBE)_X86 assembly helpers to catch unbalanced declaration Cyrill Gorcunov
2008-11-23 17:00 ` Cyrill Gorcunov
2008-11-23 17:51 ` Sam Ravnborg
2008-11-23 17:58 ` Cyrill Gorcunov [this message]
2008-11-23 18:10 ` Cyrill Gorcunov
2008-11-23 18:12 ` Sam Ravnborg
2008-11-23 18:21 ` Cyrill Gorcunov
2008-11-23 18:43 ` Cyrill Gorcunov
2008-11-23 18:46 ` Alexander van Heukelum
2008-11-23 18:54 ` Ingo Molnar
2008-11-23 18:57 ` Cyrill Gorcunov
2008-11-23 19:00 ` Ingo Molnar
2008-11-23 19:04 ` Cyrill Gorcunov
2008-11-23 19:22 ` Cyrill Gorcunov
2008-11-23 19:31 ` Ingo Molnar
2008-11-23 19:48 ` Cyrill Gorcunov
2008-11-23 22:35 ` Ingo Molnar
2008-11-24 9:10 ` Alexander van Heukelum
2008-11-24 18:04 ` H. Peter Anvin
2008-11-23 19:51 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081123175846.GF12710@localhost \
--to=gorcunov@gmail.com \
--cc=heukelum@mailshack.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox