From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Alexander van Heukelum <heukelum@mailshack.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] x86: introduce ENTRY(KPROBE)_X86 assembly helpers to catch unbalanced declaration
Date: Sun, 23 Nov 2008 22:48:28 +0300 [thread overview]
Message-ID: <20081123194828.GQ12710@localhost> (raw)
In-Reply-To: <20081123193133.GA2794@elte.hu>
[Ingo Molnar - Sun, Nov 23, 2008 at 08:31:34PM +0100]
...
| >
| > Just got an error in implementation -- we have to support nested
| > ENTRY without problem. Will check. What a surprise :-)
|
| do you mean:
|
| ENTRY(system_call)
| ENTRY(system_call_after_swapgs)
| ...
| END(system_call)
|
| that's more of a bug - system_call_after_swapgs is not a real entry
| point, we just need the label of it. Perhaps something like __ENTRY()
| for that case would be enough.
|
| nor is this one real:
|
| ENTRY(interrupt)
| ENTRY(irq_entries_start)
| ...
| END(irq_entries_start)
| END(interrupt)
|
| do we really need .irq_entries_start?
|
| I think in general we should define a flat hierarchy of entries.
|
| Ingo
|
Yeah, I meant these cases. I don't think we really need irq_entries_start
(didn't find any mention of them in tree). In case of system_call_after_swapgs
I'm not that sure, but since xen use it as a plain jmp (at least now) it
could be converted to a plain label. Ingo, I'll continue tomorrow evening --
have some other things to be done :)
- Cyrill -
next prev parent reply other threads:[~2008-11-23 19:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 16:57 [RFC -tip] x86: introduce ENTRY(KPROBE)_X86 assembly helpers to catch unbalanced declaration Cyrill Gorcunov
2008-11-23 17:00 ` Cyrill Gorcunov
2008-11-23 17:51 ` Sam Ravnborg
2008-11-23 17:58 ` Cyrill Gorcunov
2008-11-23 18:10 ` Cyrill Gorcunov
2008-11-23 18:12 ` Sam Ravnborg
2008-11-23 18:21 ` Cyrill Gorcunov
2008-11-23 18:43 ` Cyrill Gorcunov
2008-11-23 18:46 ` Alexander van Heukelum
2008-11-23 18:54 ` Ingo Molnar
2008-11-23 18:57 ` Cyrill Gorcunov
2008-11-23 19:00 ` Ingo Molnar
2008-11-23 19:04 ` Cyrill Gorcunov
2008-11-23 19:22 ` Cyrill Gorcunov
2008-11-23 19:31 ` Ingo Molnar
2008-11-23 19:48 ` Cyrill Gorcunov [this message]
2008-11-23 22:35 ` Ingo Molnar
2008-11-24 9:10 ` Alexander van Heukelum
2008-11-24 18:04 ` H. Peter Anvin
2008-11-23 19:51 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081123194828.GQ12710@localhost \
--to=gorcunov@gmail.com \
--cc=heukelum@mailshack.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox