public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Theodore Tso <tytso@mit.edu>,
	Arjan van de Ven <arjan@infradead.org>,
	Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 4/4] trace: profile all if conditionals
Date: Sun, 23 Nov 2008 21:51:22 +0100	[thread overview]
Message-ID: <20081123205122.GV6703@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0811231523070.13888@gandalf.stny.rr.com>

> My work evolves around not adding any userspace tool that is not already
> supported by busybox. I'm not against anyone else doing this work. It's 

That seems very limiting and arbitary, like tieing your hands behind your back.
Why is it ok to add code to the kernel and ok not adding code
to userland?

> This all sounds great, and perhaps someone might decide to do this. The 
> full branch tracer I added, I did in a few hours and tested on both x86 
> and PPC. That was because I was waiting on output from a test running on 
> another box that was taking a couple of hours, and I got bored.
> 
> I'm not against any of the suggestions you make. I'm just waiting for 
> someone else to do it ;-)

I just suggested the perfctr method for completeness. It actually
doesn't need much work, you can probably quite easily do it 
with the existing oprofile infrastructure to get the data,
although the output is not very nice with opreport.

But gcov is already done and existing for some time. And for
most usages unless you require minimal runtime overhead it is 
likely the better option. We also used it successfully for some 
testing here. It also has hit l-k some time ago. I don't know the 
latest merge status, but I think it hit -mm at least at some point.

-Andi


  reply	other threads:[~2008-11-23 20:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-21  7:12 [PATCH 0/4] trace: profiling branches Steven Rostedt
2008-11-21  7:12 ` [PATCH 1/4] trace: remove extra assign in branch check Steven Rostedt
2008-11-21  7:12 ` [PATCH 2/4] trace: consolidate unlikely and likely profiler Steven Rostedt
2008-11-21  7:12 ` [PATCH 3/4] trace: branch profiling should not print percent without data Steven Rostedt
2008-11-21  7:12 ` [PATCH 4/4] trace: profile all if conditionals Steven Rostedt
2008-11-21 23:20   ` Andrew Morton
2008-11-21 23:33     ` Steven Rostedt
2008-11-23 12:37       ` Ingo Molnar
2008-11-23 15:48   ` Ingo Molnar
2008-11-23 16:07     ` [PATCH] net/wireless/reg.c: fix Ingo Molnar
2008-11-23 19:43   ` [PATCH 4/4] trace: profile all if conditionals Andi Kleen
2008-11-23 19:56     ` Steven Rostedt
2008-11-23 20:24       ` Andi Kleen
2008-11-23 20:32         ` Steven Rostedt
2008-11-23 20:51           ` Andi Kleen [this message]
2008-11-23 21:38       ` Ingo Molnar
2008-11-30 10:58 ` [PATCH 0/4] trace: profiling branches Daniel Walker
2008-11-30 15:19   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081123205122.GV6703@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox