From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbYKXHad (ORCPT ); Mon, 24 Nov 2008 02:30:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751549AbYKXHaY (ORCPT ); Mon, 24 Nov 2008 02:30:24 -0500 Received: from tservice.ru ([195.178.208.66]:46602 "EHLO tservice.net.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751442AbYKXHaY (ORCPT ); Mon, 24 Nov 2008 02:30:24 -0500 Date: Mon, 24 Nov 2008 10:30:19 +0300 From: Evgeniy Polyakov To: John McCutchan Cc: Arnd Bergmann , mtk.manpages@gmail.com, Christoph Hellwig , Robert Love , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [take 3] Use pid in inotify events. Message-ID: <20081124073018.GC10119@ioremap.net> References: <20081120230612.GB6536@ioremap.net> <200811211939.46812.arnd@arndb.de> <20081122093749.GA12543@ioremap.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John. On Sun, Nov 23, 2008 at 09:08:05PM -0800, John McCutchan (john@johnmccutchan.com) wrote: > At this point I don't really want to see changes made to inotify. But, > for arguments sake, why not something like inotify_init1 that takes a > flag EXTENDED_EVENT which causes a larger event structure to be used. > Something like, > > struct inotify_event_extended > { > s32 wd; > u32 mask; > u32 cookie; > u32 data[4]; > char path[0]; > } > > The data array could be used to store arbitrary extra information, > specified by flags. What will happen when above array is not enough to store needed info? Although I do not see any reason to send start/offset for the IO itself, but if it will be decided to do so, above array already is not large enough. I think I will cook up preliminary patch to add nested attributes into event structure like I described previously in the thread to get people involved with working example. -- Evgeniy Polyakov