From: Andi Kleen <andi@firstfloor.org>
To: Andreas Schwab <schwab@suse.de>
Cc: "Andi Kleen" <andi@firstfloor.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Török Edwin" <edwintorok@gmail.com>,
"Ingo Molnar" <mingo@elte.hu>,
"Arjan van de Ven" <arjan@linux.intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Steven Rostedt" <rostedt@goodmis.org>,
"David Howells" <dhowells@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] __used is needed for function referenced only from inline asm
Date: Mon, 24 Nov 2008 10:53:56 +0100 [thread overview]
Message-ID: <20081124095356.GW6703@one.firstfloor.org> (raw)
In-Reply-To: <je7i6twjsp.fsf@sykes.suse.de>
On Mon, Nov 24, 2008 at 10:32:54AM +0100, Andreas Schwab wrote:
> Andi Kleen <andi@firstfloor.org> writes:
>
> > Geert Uytterhoeven <geert@linux-m68k.org> writes:
> >>> */
> >>> -static void noinline __sched
> >>> +static __used noinline void __sched
> >>
> >> Perhaps we should incorporate it into `noinline'?
> >
> > No, we use noinline for other reasons too. Perhaps the other way
> > around though.
>
> Or just drop noinline here (since there are no callers to inline into
> anyway).
That would seem fragile to me because it could hit later again when
someone changes the code or adds debugging code. Better always
have full annotations, even if you don't need them all at the moment.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-11-24 9:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 8:17 [PATCH] __used is needed for function referenced only from inline asm Török Edwin
2008-11-24 8:57 ` Geert Uytterhoeven
2008-11-24 9:22 ` Andi Kleen
2008-11-24 9:32 ` Andreas Schwab
2008-11-24 9:53 ` Andi Kleen [this message]
2008-11-24 9:04 ` Ingo Molnar
2008-11-24 9:50 ` Török Edwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081124095356.GW6703@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=arjan@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=edwintorok@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=schwab@suse.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox