From: Samuel Ortiz <sameo@openedhand.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: Switch WM8350 revision detection to a feature based model
Date: Mon, 24 Nov 2008 20:25:32 +0100 [thread overview]
Message-ID: <20081124192531.GA2604@sortiz.org> (raw)
In-Reply-To: <20081124133116.GA31269@rakim.wolfsonmicro.main>
On Mon, Nov 24, 2008 at 01:31:16PM +0000, Mark Brown wrote:
> On Mon, Nov 24, 2008 at 11:37:55AM +0100, Samuel Ortiz wrote:
>
> > Dont you prefer to use the WM8350_REV_* values in your code rather than some
> > undocumented constants like that ?
> > I understand that reading the code below will make those constants obvious,
> > but still...
>
> I don't find them enormously helpful, TBH - the constant gets used in
> exactly one place and there's been a bit of skew between what some of
> the ID registers are called and thier actual meaning which doesn't help.
>
> I'll repost with the #defines for the revisons added back, though.
Thanks for the patches. Both of them are now sitting in my for-next branch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2008-11-24 19:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 16:46 [PATCH 1/2] mfd: Switch WM8350 revision detection to a feature based model Mark Brown
2008-11-19 16:47 ` [PATCH 2/2] mfd: Refactor WM8350 chip identification Mark Brown
2008-11-24 10:37 ` [PATCH 1/2] mfd: Switch WM8350 revision detection to a feature based model Samuel Ortiz
2008-11-24 13:31 ` Mark Brown
2008-11-24 19:25 ` Samuel Ortiz [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-24 15:53 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081124192531.GA2604@sortiz.org \
--to=sameo@openedhand.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox