Re: [PATCH] crypto: fix error flow of crypto/testmgr.c:test_comp()

Patrick McHardy
2008-11-25T17:27:25Z

Ingo Molnar wrote:
> btw, on a related note, there's a couple of networking related warning
> fixes/annotations i've got queued up.
>
> I've got 37 commits of that nature in the tip/warnings/* topic
> branches:
> [...]
>
> They are done mainly so that we can notice the warnings we introduce
> via any of the -tip trees - but we analyze and look at all other types
> of upstream kernel warnings as well.
>
> I'll thus keep these commits indefinitely - but if someone from the
> networking side would like to work with us to pick them up and
> eventually nurse them upstream, that would be great!
>
> One thing is not really feasible: there's just too many of them for me
> to spend 10 minutes on each to submit them with a proper Cc:, etc.
> (such overhead mounts up quickly if you do the numbers)
>
> So i've attached them below as a dump of patches. If someone wants to
> cherry-pick bits of them, they are also available in
> tip/auto-warnings-next:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git auto-warnings-next
>
> Warning: some of them might be bad, so please double check the
> analysis.

> commit c390a3784564c1fb2183e4a31ea39a9beb47d034
> Author: Ingo Molnar <mingo@elte.hu>
> Date: Tue Nov 25 11:31:28 2008 +0100
>
> fix warning in net/netfilter/nf_conntrack_ftp.c

I've picked up this one in my nf-next-2.6.git tree.

> commit decc1656e870c9e5bd94f2357b8496b8da6c2e73
> Author: Ingo Molnar <mingo@elte.hu>
> Date: Sat Oct 18 19:14:40 2008 +0200
>
> fix warning in net/netfilter/nf_conntrack_proto_sctp.c

This one is already fixed differently in my tree.

> commit b5a7c2b9e1a1b4d80da5d66b330545fdeafe1dad
> Author: Ingo Molnar <mingo@elte.hu>
> Date: Fri Oct 17 19:48:51 2008 +0200
>
> fix warning in net/netfilter/nf_conntrack_proto_tcp.c

I've also picked up this one.