From: Magnus Damm <magnus.damm@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>,
lethal@linux-sh.org, akpm@linux-foundation.org
Subject: [PATCH] Free setup_irq() interrupt using free_irq()
Date: Tue, 25 Nov 2008 22:13:41 +0900 [thread overview]
Message-ID: <20081125131341.8640.69069.sendpatchset@rx1.opensource.se> (raw)
From: Magnus Damm <damm@igel.co.jp>
This patch adds support for using free_irq() on interrupts
allocated with setup_irq(). Without this patch the kernel
will try to kfree() the struct irqaction passed as argument
to setup_irq().
Signed-off-by: Magnus Damm <damm@igel.co.jp>
---
include/linux/interrupt.h | 2 ++
kernel/irq/manage.c | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
--- 0001/include/linux/interrupt.h
+++ work/include/linux/interrupt.h 2008-11-25 19:43:40.000000000 +0900
@@ -48,6 +48,7 @@
* IRQF_IRQPOLL - Interrupt is used for polling (only the interrupt that is
* registered first in an shared interrupt is considered for
* performance reasons)
+ * IRQF_STATIC - Interrupt requested with setup_irq(), do not kfree().
*/
#define IRQF_DISABLED 0x00000020
#define IRQF_SAMPLE_RANDOM 0x00000040
@@ -57,6 +58,7 @@
#define IRQF_PERCPU 0x00000400
#define IRQF_NOBALANCING 0x00000800
#define IRQF_IRQPOLL 0x00001000
+#define IRQF_STATIC 0x00002000
typedef irqreturn_t (*irq_handler_t)(int, void *);
--- 0001/kernel/irq/manage.c
+++ work/kernel/irq/manage.c 2008-11-25 19:44:14.000000000 +0900
@@ -509,6 +509,7 @@ int setup_irq(unsigned int irq, struct i
{
struct irq_desc *desc = irq_to_desc(irq);
+ act->flags |= IRQF_STATIC;
return __setup_irq(irq, desc, act);
}
@@ -585,7 +586,8 @@ void free_irq(unsigned int irq, void *de
local_irq_restore(flags);
}
#endif
- kfree(action);
+ if (!(action->flags & IRQF_STATIC))
+ kfree(action);
return;
}
printk(KERN_ERR "Trying to free already-free IRQ %d\n", irq);
reply other threads:[~2008-11-25 13:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125131341.8640.69069.sendpatchset@rx1.opensource.se \
--to=magnus.damm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox