From: Magnus Damm <magnus.damm@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, lethal@linux-sh.org,
johnstul@us.ibm.com, magnus.damm@gmail.com, mingo@redhat.com,
Magnus Damm <magnus.damm@gmail.com>,
tglx@linutronix.de
Subject: [RFC] Reentrant clock sources
Date: Tue, 25 Nov 2008 22:28:23 +0900 [thread overview]
Message-ID: <20081125132823.8698.83248.sendpatchset@rx1.opensource.se> (raw)
Hi everyone,
Is there any special reason behind the non-reentrant clock source
code? I'm writing some timer help code and getting the struct
clocksource as argument to the callbacks would make the code much
cleaner and better.
Extending the callbacks to be able to start and stop clock sources
for improved power management would be good too in my opinion.
Any thoughts?
I realize that there are quite a few clock source drivers
that need to be modified, any recommendation on which tree
to do it against and how to split up the patch? Thanks.
Signed-off-by: Magnus Damm <damm@igel.co.jp>
---
include/linux/clocksource.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- 0001/include/linux/clocksource.h
+++ work/include/linux/clocksource.h 2008-11-25 21:07:13.000000000 +0900
@@ -61,14 +61,14 @@ struct clocksource {
char *name;
struct list_head list;
int rating;
- cycle_t (*read)(void);
+ cycle_t (*read)(struct clocksource *cs);
cycle_t mask;
u32 mult;
u32 mult_orig;
u32 shift;
unsigned long flags;
- cycle_t (*vread)(void);
- void (*resume)(void);
+ cycle_t (*vread)(struct clocksource *cs);
+ void (*resume)(struct clocksource *cs);
#ifdef CONFIG_IA64
void *fsys_mmio; /* used by fsyscall asm code */
#define CLKSRC_FSYS_MMIO_SET(mmio, addr) ((mmio) = (addr))
@@ -170,7 +170,7 @@ static inline u32 clocksource_hz2mult(u3
*/
static inline cycle_t clocksource_read(struct clocksource *cs)
{
- return cs->read();
+ return cs->read(cs);
}
/**
next reply other threads:[~2008-11-25 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 13:28 Magnus Damm [this message]
2008-11-25 14:55 ` [RFC] Reentrant clock sources Ingo Molnar
2008-11-25 21:22 ` Thomas Gleixner
2008-11-26 3:07 ` Ingo Molnar
2008-11-26 3:20 ` john stultz
2008-11-26 3:52 ` Ingo Molnar
2008-11-26 5:21 ` Magnus Damm
2008-11-26 5:32 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125132823.8698.83248.sendpatchset@rx1.opensource.se \
--to=magnus.damm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=johnstul@us.ibm.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox