From: Alexey Dobriyan <adobriyan@gmail.com>
To: Joe Korty <joe.korty@ccur.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add per-cpu indexing to /proc/timer_list
Date: Wed, 26 Nov 2008 07:50:04 +0300 [thread overview]
Message-ID: <20081126045004.GA3278@x200.localdomain> (raw)
In-Reply-To: <20081125231445.GA24326@tsunami.ccur.com>
On Tue, Nov 25, 2008 at 06:14:45PM -0500, Joe Korty wrote:
> Per-cpu indexing of /proc/timer_list.
>
> /proc/timer_list, potentially a very large file, is in
> danger of overflowing its seq_file buffer. So 'split up'
> the buffering on cpu ID boundaries. This should make this
> file more likely to be useful on largish SMP systems.
What do you mean?
You can't overflow seq_file buffer unless kmalloc() will fail large
allocation. And changing internals doesn't change amount of stuff
to be shown, which is the only thing which can lead to large buffer
need.
> The model followed is that in /proc/interrupts, which
> splits up its buffering on (most) irq boundaries.
next prev parent reply other threads:[~2008-11-26 4:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 22:44 [PATCH] Fix overbroad /proc/timer_list file permissions Joe Korty
2008-11-25 23:14 ` [PATCH] Add per-cpu indexing to /proc/timer_list Joe Korty
2008-11-26 4:50 ` Alexey Dobriyan [this message]
2008-11-26 14:39 ` Joe Korty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126045004.GA3278@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=joe.korty@ccur.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox