From: Andrey Mirkin <major@openvz.org>
To: Louis.Rilling@kerlabs.com
Cc: Andrey Mirkin <major@openvz.org>,
orenl@cs.columbia.edu, containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Add flags for user-space and in-kernel process creation
Date: Wed, 26 Nov 2008 08:55:45 +0400 [thread overview]
Message-ID: <200811260755.46949.major@openvz.org> (raw)
In-Reply-To: <20081124160211.GE27238@hawkmoon.kerlabs.com>
On Monday 24 November 2008 19:02 Louis Rilling wrote:
> On 24/11/08 18:39 +0300, Andrey Mirkin wrote:
> > Introduce 2 flags for user-space and in-kernel process creation during
> > restart procedure.
> > Also a stub function for in-kernel process restart is introduced.
>
> [...]
>
> > diff --git a/checkpoint/sys.c b/checkpoint/sys.c
> > index 7745500..e4a9287 100644
> > --- a/checkpoint/sys.c
> > +++ b/checkpoint/sys.c
> > @@ -264,8 +264,8 @@ asmlinkage long sys_restart(int crid, int fd,
> > unsigned long flags) pid_t pid;
> > int ret;
> >
> > - /* no flags for now */
> > - if (flags)
> > + if ((flags & (CR_CTX_RSTR_IN_USERSPACE | CR_CTX_RSTR_IN_USERSPACE)) ==
> > + (CR_CTX_RSTR_IN_USERSPACE | CR_CTX_RSTR_IN_USERSPACE))
>
> I guess that the intent was:
> + if ((flags & (CR_CTX_RSTR_IN_USERSPACE | CR_CTX_RSTR_IN_KERNEL)) ==
> + (CR_CTX_RSTR_IN_USERSPACE | CR_CTX_RSTR_IN_KERNEL))
>
> ?
Oh, of course it should be like this.
I've sent wrong patch. Will resend correct one.
Andrey
next prev parent reply other threads:[~2008-11-26 4:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 15:39 [PATCH 0/2] In-kernel process restart Andrey Mirkin
2008-11-24 15:39 ` [PATCH 1/2] Add flags for user-space and in-kernel process creation Andrey Mirkin
2008-11-24 15:39 ` [PATCH 2/2] Add support for in-kernel process creation during restart Andrey Mirkin
2008-11-25 0:45 ` Alexey Dobriyan
2008-11-26 5:07 ` Andrey Mirkin
2008-11-25 20:17 ` Oren Laadan
2008-11-26 11:58 ` Andrey Mirkin
2008-11-24 16:02 ` [PATCH 1/2] Add flags for user-space and in-kernel process creation Louis Rilling
2008-11-26 4:55 ` Andrey Mirkin [this message]
2008-11-25 20:02 ` [PATCH 0/2] In-kernel process restart Oren Laadan
2008-11-26 11:44 ` Andrey Mirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811260755.46949.major@openvz.org \
--to=major@openvz.org \
--cc=Louis.Rilling@kerlabs.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orenl@cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox