public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org,
	Christoph Lameter <cl@linux-foundation.org>
Subject: Re: core_param: call these really, really early.
Date: Wed, 26 Nov 2008 09:08:46 +0100	[thread overview]
Message-ID: <20081126080846.GA7168@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <200811200123.41353.rusty@rustcorp.com.au>

On Thu, Nov 20, 2008 at 01:23:41AM +1030, Rusty Russell wrote:
> As soon as we have command line, so even before early_param.  They
> just set vars, so it makes sense to do them as early as possible.
> 
> This allows them to replace early_param, and fixes a bug in the new
> cpu_alloc implementation patches which was a complete PITA to find.
> 
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

[...]

> diff -r 65aebfe44ef1 init/main.c
> --- a/init/main.c	Wed Nov 19 22:47:52 2008 +1030
> +++ b/init/main.c	Wed Nov 19 23:58:08 2008 +1030
> @@ -569,6 +588,10 @@
>  	setup_arch(&command_line);
>  	mm_init_owner(&init_mm, &init_task);
>  	setup_command_line(command_line);
> +	parse_args("Core params", command_line, __start___core_param,
> +		   __stop___core_param - __start___core_param,
> +		   unknown_core_ok);
> +
>  	unwind_setup();
>  	setup_per_cpu_areas();
>  	setup_nr_cpu_ids();

...but setup_arch() calls parse_early_param(). So how is this earlier
than early_param?

  reply	other threads:[~2008-11-26  8:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-19 14:53 core_param: call these really, really early Rusty Russell
2008-11-26  8:08 ` Heiko Carstens [this message]
2008-11-27  8:02   ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081126080846.GA7168@osiris.boeblingen.de.ibm.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox