Re: [PATCH] fakephp: Allocate PCI resources before adding the device

[Matthew Wilcox <matthew@wil.cx>]

On Wed, Nov 26, 2008 at 05:44:35PM -0800, Trent Piepho wrote:
> Is there a reason you had to change it?  It breaks an existing interface.
> It's clearly more inefficient and complicated to find a slot using it.  The
> exiting PCI device name, like "0000:01:00.0", has been used in the sysfs
> interface and with tools like lspci since forever.  Why should
> /sys/bus/pci/slots use different names from /sys/bus/pci/devices for the
> same device?

Because fakephp was the odd one out.  Every other hotplug driver
registers a slot number and puts the address in the directory.  We're
making hotplug drivers simpler (by sharing more of the logic in the
core) and so fakephp had to change to match the other drivers.  I'm
sorry for your inconvenience, but it's necessary.

We can discuss other ways to make your life better, but it can't be
changed back to one 'slot' per PCI function.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."