From: Ingo Molnar <mingo@elte.hu>
To: Joerg Roedel <joerg.roedel@amd.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
stable@kernel.org
Subject: Re: [PATCH] x86: always define DECLARE_PCI_UNMAP* macros
Date: Thu, 27 Nov 2008 12:45:25 +0100 [thread overview]
Message-ID: <20081127114525.GC29013@elte.hu> (raw)
In-Reply-To: <1227210596-1196-1-git-send-email-joerg.roedel@amd.com>
* Joerg Roedel <joerg.roedel@amd.com> wrote:
> Currently these macros evaluate to a no-op except the kernel is
> compiled with GART or Calgary support. But we also need these macros
> when we have SWIOTLB, VT-d or AMD IOMMU in the kernel. Since we
> always compile at least with SWIOTLB we can define these macros
> always. This patch is also for stable backport for the same reason
> the SWIOTLB default selection patch is.
>
> Cc: stable@kernel.org
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
> arch/x86/include/asm/pci_64.h | 14 --------------
> 1 files changed, 0 insertions(+), 14 deletions(-)
applied to tip/x86/urgent (for v2.6.28), as this is a DMA mapping
bugfix for IOMMUs. If the AMD IOMMU is turned on in the .config but
CONFIG_GART_IOMMU is off (a rare but possible combo), we'd leak on
unmap and crash the box quickly.
Jesse, is that path of upstream merge fine with you?
Ingo
next prev parent reply other threads:[~2008-11-27 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 19:49 [PATCH] x86: always define DECLARE_PCI_UNMAP* macros Joerg Roedel
2008-11-27 11:45 ` Ingo Molnar [this message]
2008-11-27 17:04 ` Jesse Barnes
2008-11-28 17:45 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081127114525.GC29013@elte.hu \
--to=mingo@elte.hu \
--cc=iommu@lists.linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox