From: Andi Kleen <andi@firstfloor.org>
To: eranian@gmail.com
Cc: Andi Kleen <andi@firstfloor.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mingo@elte.hu, x86@kernel.org, sfr@canb.auug.org.au
Subject: Re: [patch 05/24] perfmon: X86 generic code (x86)
Date: Thu, 27 Nov 2008 13:45:01 +0100 [thread overview]
Message-ID: <20081127124501.GL6703@one.firstfloor.org> (raw)
In-Reply-To: <7c86c4470811270428r76702954se8f6e005481a6a35@mail.gmail.com>
> What if a threads reprograms the counters while another is reading them?
In the worst case you get an invalid event, which is then discarded.
I think. I've never tried to understand it in all details, but
at least it seems to work.
> How is the buffer reset?
drivers/oprofile/cpu_buffer.c:
/* Resets the cpu buffer to a sane state. */
void cpu_buffer_reset(struct oprofile_cpu_buffer *cpu_buf)
{
/* reset these to invalid values; the next sample
* collected will populate the buffer with proper
* values to initialize the buffer
*/
cpu_buf->last_is_kernel = -1;
cpu_buf->last_task = NULL;
}
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-11-27 12:34 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 8:42 [patch 05/24] perfmon: X86 generic code (x86) eranian
2008-11-26 11:33 ` Andi Kleen
2008-11-26 12:05 ` Stephen Rothwell
2008-11-26 12:22 ` Andi Kleen
2008-11-26 12:48 ` Stephen Rothwell
2008-11-26 13:32 ` Thomas Gleixner
2008-11-26 13:56 ` stephane eranian
2008-11-26 16:38 ` Thomas Gleixner
2008-11-27 9:51 ` stephane eranian
2008-11-27 10:56 ` Thomas Gleixner
2008-11-27 11:37 ` David Miller
2008-11-27 14:40 ` Thomas Gleixner
2008-11-26 13:35 ` Thomas Gleixner
2008-11-26 14:00 ` Andi Kleen
2008-11-26 21:18 ` Thomas Gleixner
2008-11-26 21:37 ` stephane eranian
2008-11-26 23:16 ` Thomas Gleixner
2008-11-27 9:38 ` stephane eranian
2008-11-26 22:54 ` Thomas Gleixner
2008-11-27 10:06 ` Andi Kleen
2008-11-27 10:09 ` stephane eranian
2008-11-27 10:29 ` Thomas Gleixner
2008-11-27 11:31 ` Andi Kleen
2008-11-27 11:35 ` stephane eranian
2008-11-27 11:42 ` David Miller
2008-11-27 11:49 ` Thomas Gleixner
2008-11-27 12:38 ` Andi Kleen
2008-11-27 12:31 ` stephane eranian
2008-11-27 12:46 ` Andi Kleen
2008-11-27 13:32 ` Thomas Gleixner
2008-11-27 13:37 ` stephane eranian
2008-11-27 13:51 ` Andi Kleen
2008-11-27 13:50 ` Andi Kleen
2008-11-27 11:52 ` Peter Zijlstra
2008-11-27 12:04 ` stephane eranian
2008-11-27 12:16 ` Peter Zijlstra
2008-11-27 12:32 ` Andi Kleen
2008-11-27 12:28 ` stephane eranian
2008-11-27 12:45 ` Andi Kleen [this message]
2008-11-27 13:30 ` stephane eranian
2008-11-27 13:49 ` Andi Kleen
2008-11-27 13:47 ` stephane eranian
-- strict thread matches above, loose matches on Subject: below --
2008-11-25 21:36 eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081127124501.GL6703@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=eranian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox