The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Tim Bird <tim.bird@am.sony.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/function-graph-tracer: adjustments of the trace informations
Date: Fri, 28 Nov 2008 10:25:53 +0100	[thread overview]
Message-ID: <20081128092553.GA7040@elte.hu> (raw)
In-Reply-To: <20081128091800.GA1725@elte.hu>


another thing which i'm sure you are aware of:

# tracer: function_graph
#
#           TASK-PID    CPU#    TIMESTAMP  FUNCTION
#              | |       |          |         |
 ------------------------------------------
 | 1)  S99local--1  =>  ssh-1724
 ------------------------------------------
 
 1)      0.867 us |        }
 1)               |        mark_page_accessed() {
 1)      0.293 us |          constant_test_bit();
 1)      0.294 us |          constant_test_bit();
[...]

the header description is now out of of sync :-)

Also, we should probably not start the trace with a PID-switch event. 
the last_pid[] markers are probably out of sync when we start printing 
the trace.

So the output should probably be something like:

# tracer: function_graph
#
# CPU      COST     FUNCTION-GRAPH
# |          |       |        

 1)      0.867 us |        }
 1)               |        mark_page_accessed() {
 1)      0.293 us |          constant_test_bit();
 1)      0.294 us |          constant_test_bit();
[...]

	Ingo

  reply	other threads:[~2008-11-28  9:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-27 23:42 [PATCH] tracing/function-graph-tracer: adjustments of the trace informations Frederic Weisbecker
2008-11-28  9:18 ` Ingo Molnar
2008-11-28  9:25   ` Ingo Molnar [this message]
2008-11-28 13:58     ` Frédéric Weisbecker
2008-11-28 19:22     ` Ingo Molnar
2008-11-29  3:40       ` Frédéric Weisbecker
2008-11-29 10:59         ` Peter Zijlstra
2008-11-28 13:55   ` Frédéric Weisbecker
2008-11-28 14:17     ` Ingo Molnar
2008-11-29  3:24       ` Frédéric Weisbecker
2008-11-29 14:19         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081128092553.GA7040@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tim.bird@am.sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox