From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] kill FMODE_NDELAY_NOW
Date: Sun, 30 Nov 2008 13:07:23 +0000 [thread overview]
Message-ID: <20081130130723.GX28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20081105135842.GB4393@lst.de>
On Wed, Nov 05, 2008 at 02:58:42PM +0100, Christoph Hellwig wrote:
> Update FMODE_NDELAY before each ioctl call so that we can kill the
> magic FMODE_NDELAY_NOW. It would be even better to do this directly
> in setfl(), but for that we'd need to have FMODE_NDELAY for all files,
> not just block special files.
We _can't_ do that in setfl() - not unless you such bdev method.
Note that there's a bunch of cases where O_NDELAY at open() is used
to get very different semantics and we want ->release() to see the
matching value.
prev parent reply other threads:[~2008-11-30 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 13:58 [PATCH 1/2] kill FMODE_NDELAY_NOW Christoph Hellwig
2008-11-30 13:07 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081130130723.GX28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox