Re: [PATCH] fix pktcdvd breakage from commit e105b8bfc769b0545b6f0f395179d1e43cbee822

Kay Sievers
2008-11-30T13:41:27Z

On Sun, Nov 30, 2008 at 14:32, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Sun, Nov 30, 2008 at 02:25:43PM +0100, Kay Sievers wrote:
>
>> Pktcdvd creates char _and_ block device nodes at the same time, while
>> the char nodes are not allocated, but created and conflict in
>> /sys/dev/ with properly allocated ones from other subsystems. Your
>> patch just papers over this bug.
>
> Where the hell is it creating any char device nodes? Show me.

Here the hell it is:
pd->dev = device_create(class_pktcdvd, NULL, pd->pkt_dev, NULL,
"%s", pd->name);

The bogus "pkt_dev", it's a char dev_t value, but because the char
dev_t value is already validly used by other subsystems, it will cause
the broken /sys/dev/ link. That's the real bug.

Kay