From: Pierre Ossman <drzeus@drzeus.cx>
To: Philip Langdale <philipl@overt.org>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
sdhci-devel@list.drzeus.cx, Matthew Garrett <mjg59@srcf.ucam.org>,
Frans Pop <elendil@planet.nl>
Subject: Re: [PATCH] ricoh_mmc: Use suspend/resume_noirq
Date: Sun, 30 Nov 2008 23:49:57 +0100 [thread overview]
Message-ID: <20081130234957.426ded07@mjolnir.drzeus.cx> (raw)
In-Reply-To: <492DFB39.1050503@overt.org>
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
On Wed, 26 Nov 2008 17:43:21 -0800
Philip Langdale <philipl@overt.org> wrote:
> If ricoh_mmc suspends before sdhci_pci, it will pull the card
> out from under the controller, which could leave the system in
> a very confused state.
>
> Using suspend/resume_noirq ensures that sdhci_pci suspends first
> and resumes second.
>
> Signed-off-by: Philip Langdale <philipl@overt.org>
> ---
You get some odd whitespace damage on your patches. Please see if you
can get that fixed, or resend the patch as an attachment.
Rgds
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2008-11-30 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 1:43 [PATCH] ricoh_mmc: Use suspend/resume_noirq Philip Langdale
2008-11-28 22:18 ` Frans Pop
2008-11-30 22:49 ` Pierre Ossman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081130234957.426ded07@mjolnir.drzeus.cx \
--to=drzeus@drzeus.cx \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=philipl@overt.org \
--cc=sdhci-devel@list.drzeus.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox