RE: [PATCH 0/13 v7] PCI: Linux kernel SR-IOV support

Rose, Gregory V
2008-12-17T16:46:20Z

[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]

As noted in the attached email to the netdev list, we (e1000_devel) will support the API.

- Greg Rose

-----Original Message-----
From: kvm-owner@vger.kernel.org [mailto:kvm-owner@vger.kernel.org] On Behalf Of Greg KH
Sent: Tuesday, December 16, 2008 10:06 PM
To: Jike Song
Cc: Jesse Barnes; Zhao, Yu; linux-pci@vger.kernel.org; achiang@hp.com; bjorn.helgaas@hp.com; grundler@parisc-linux.org; mingo@elte.hu; matthew@wil.cx; randy.dunlap@oracle.com; rdreier@cisco.com; horms@verge.net.au; yinghai@kernel.org; linux-kernel@vger.kernel.org; kvm@vger.kernel.org; virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 0/13 v7] PCI: Linux kernel SR-IOV support

On Wed, Dec 17, 2008 at 10:37:54AM +0800, Jike Song wrote:
> Jesse Barnes wrote:
> > Given a respin of 10-13 I think it's reasonable to merge this into 2.6.29, but
> > I'd be much happier about it if we got some driver code along with it, so as
> > not to have an unused interface sitting around for who knows how many
> > releases. Is that reasonable? Do you know if any of the corresponding PF/VF
> > driver bits are ready yet?
>
> Hi Jesse,
>
> Yu Zhao has posted a patch set with subject "SR-IOV driver example"
> at November 26, which illustrated the usage of SR-IOV API in Intel 82576 VF/PF
> drivers;-)

Yes, but that driver was soundly rejected by the network driver
maintainers, so I wouldn't go around showing that as your primary
example of how to use this interface :)

The point is valid, I don't think these apis should go into the tree
without a driver or some other code using them. Otherwise they make no
sense at all to have in-tree.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Type: message/rfc822, Size: 5600 bytes --]

From: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
To: "Zhao, Yu" <yu.zhao@intel.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "greg@kroah.com" <greg@kroah.com>, "matthew@wil.cx" <matthew@wil.cx>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "Nakajima, Jun" <jun.nakajima@intel.com>, "Rose, Gregory V" <gregory.v.rose@intel.com>
Subject: Re: [SR-IOV driver example 0/3 resend] introduction
Date: Tue, 2 Dec 2008 19:12:18 -0800
Message-ID: <9929d2390812021912ua5ddeafo3ae4a5759ffc4c4e@mail.gmail.com>

On Tue, Dec 2, 2008 at 1:27 AM, Yu Zhao <yu.zhao@intel.com> wrote:
> SR-IOV drivers of Intel 82576 NIC are available. There are two parts
> of the drivers: Physical Function driver and Virtual Function driver.
> The PF driver is based on the IGB driver and is used to control PF to
> allocate hardware specific resources and interface with the SR-IOV core.
> The VF driver is a new NIC driver that is same as the traditional PCI
> device driver. It works in both the host and the guest (Xen and KVM)
> environment.
>
> These two drivers are testing versions and they are *only* intended to
> show how to use SR-IOV API.
>
> Intel 82576 NIC specification can be found at:
> http://download.intel.com/design/network/datashts/82576_Datasheet_v2p1.pdf
>
> [SR-IOV driver example 0/3 resend] introduction
> [SR-IOV driver example 1/3 resend] PF driver: hardware specific operations
> [SR-IOV driver example 2/3 resend] PF driver: integrate with SR-IOV core
> [SR-IOV driver example 3/3 resend] VF driver: an independent PCI NIC driver
> --
>

First of all, we (e1000-devel) do support the SR-IOV API.

With that said, NAK on the driver changes. We were not involved in
these changes and are currently working on a version of the drivers
that will make them acceptable for kernel inclusion.

--
Cheers,
Jeff