* [PATCH 1/6] cpumask: make CONFIG_NR_CPUS always valid.
@ 2008-12-01 8:16 Rusty Russell
0 siblings, 0 replies; only message in thread
From: Rusty Russell @ 2008-12-01 8:16 UTC (permalink / raw)
To: linux-kernel; +Cc: Mike Travis
Impact: cleanup
Currently we have NR_CPUS, which is 1 on UP, and CONFIG_NR_CPUS on
SMP. If we make CONFIG_NR_CPUS always valid (and always 1 on !SMP),
we can skip the middleman.
This also allows us to find and check all the remaining NR_CPUS users.
To avoid breaking every arch, we cheat and do this for the moment
in the header if the arch doesn't.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Mike Travis <travis@sgi.com>
---
include/linux/threads.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff -r 329e9ec99074 include/linux/threads.h
--- a/include/linux/threads.h Thu Oct 23 23:46:33 2008 +1100
+++ b/include/linux/threads.h Thu Oct 23 23:50:50 2008 +1100
@@ -8,16 +8,16 @@
*/
/*
- * Maximum supported processors that can run under SMP. This value is
- * set via configure setting. The maximum is equal to the size of the
- * bitmasks used on that platform, i.e. 32 or 64. Setting this smaller
- * saves quite a bit of memory.
+ * Maximum supported processors. Setting this smaller saves quite a
+ * bit of memory. Use nr_cpu_ids instead of this except for static bitmaps.
*/
-#ifdef CONFIG_SMP
+#ifndef CONFIG_NR_CPUS
+/* FIXME: This should be fixed in the arch's Kconfig */
+#define CONFIG_NR_CPUS 1
+#endif
+
+/* Places which use this should consider cpumask_var_t. */
#define NR_CPUS CONFIG_NR_CPUS
-#else
-#define NR_CPUS 1
-#endif
#define MIN_THREADS_LEFT_FOR_ROOT 4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-12-01 8:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-01 8:16 [PATCH 1/6] cpumask: make CONFIG_NR_CPUS always valid Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox