From: Andrew Morton <akpm@linux-foundation.org>
To: balbir@linux.vnet.ibm.com
Cc: penberg@cs.helsinki.fi, jdike@addtoit.com,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net, stable@kernel.org
Subject: Re: [PATCH][UML] Boot broken due to buffer overrun
Date: Tue, 2 Dec 2008 12:17:07 -0800 [thread overview]
Message-ID: <20081202121707.e1623f89.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081129122039.GA31635@balbir.in.ibm.com>
On Sat, 29 Nov 2008 17:50:39 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> * Pekka Enberg <penberg@cs.helsinki.fi> [2008-11-29 12:21:46]:
>
> > Hi Balbir,
> >
> > On Sat, Nov 29, 2008 at 12:08 PM, Balbir Singh
> > <balbir@linux.vnet.ibm.com> wrote:
> > > mconsole_init() passed 256 bytes as length in os_create_unix_socket, while
> > > the sizeof UNIX_PATH_MAX is 108. This patch fixes that problem and avoids
> > > a big overrun bug reported on UML bootup.
> >
> > Maybe mention that ->sun_path in struct sockaddr_un is UNIX_PATH_MAX
> > long which causes the problem?
> >
>
> Yes, the changelog can definitely add that to the changelog, I'll
> resend the patch if Jeff asks for it.
Jeff's been quiet lately - I'll merge this one.
I also tagged it for -stable, subject to Jeff's OK. I'm wondering why
this wasn't observed in earlier kernels?
next prev parent reply other threads:[~2008-12-02 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-29 10:08 [PATCH][UML] Boot broken due to buffer overrun Balbir Singh
2008-11-29 10:21 ` Pekka Enberg
2008-11-29 12:20 ` Balbir Singh
2008-12-02 20:17 ` Andrew Morton [this message]
2008-12-06 1:16 ` Américo Wang
2008-12-06 5:44 ` Balbir Singh
2008-11-29 13:03 ` Américo Wang
2008-11-30 3:01 ` Balbir Singh
2008-12-01 23:35 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081202121707.e1623f89.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=stable@kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox