Re: [PATCH 2/2 update] misc: Add dell-laptop driver

Henrique de Moraes Holschuh
2008-12-05T02:06:12Z

(I feel weird replying to "none" :-) )

On Wed, 03 Dec 2008, none wrote:
> > + wifi_rfkill->get_state = dell_wifi_get;
>
> The rfkill doc (and code) say that you also need to initialize
> wifi_rfkill->state to the current state of the hardware.

I may have screwed up and ommited from the docs the fact that it is not
strictly necessary to do so if you provide rfkill->get_state. So that is
not a serious problem with the patch at all.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh