Re: [PATCH] remove isa stuff from smc91x driver

Luotao Fu
2008-12-03T15:19:35Z

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

On Wed, Dec 03, 2008 at 02:52:35PM +0000, Alan Cox wrote:
> On Wed, 3 Dec 2008 15:48:21 +0100
> Luotao Fu <l.fu@pengutronix.de> wrote:
>
> > From: Luotao Fu <lfu@pengutronix.de>
> >
> > ISA support in smc91x is incomplete. I doubt there're any smc91x isa card.
> > This driver is greatly used on arm pxa platforms. Hence we remove the
> > isa stuff from smc91x driver.
>
> This makes no sense. It is protected by an ifdef anyway so doesn't affect
> ARM

The isa part in smc91x does nothing at all. Get you a unused variable warning if
you turn ISA on and compile it. The io table is defined and not used at all.
Neither does the io address and irq by parameter. I think that these are waste
code and should be removed.

Cheers
Luotao Fu
--
Dipl.-Ing. Luotao Fu | Phone: +49-5121-206917-5004
Pengutronix - Linux Solutions for Science and Industry
Entwicklungszentrum Nord http://www.pengutronix.de

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]