Re: [PATCH] remove isa stuff from smc91x driver

Steve.Glendinning
2008-12-03T16:46:46Z

Hi all,

> > > ISA support in smc91x is incomplete. I doubt there're any smc91xisa
card.
> > > This driver is greatly used on arm pxa platforms. Hence we remove
the
> > > isa stuff from smc91x driver.
> >
> > This makes no sense. It is protected by an ifdef anyway so doesn't
affect
> > ARM
>
> The isa part in smc91x does nothing at all. Get you a unused
> variable warning if
> you turn ISA on and compile it. The io table is defined and not used at
all.
> Neither does the io address and irq by parameter. I think that theseare
waste
> code and should be removed.

SMSC LAN91C111 *does* still exist on ISA platforms (for example PC104),
but
Luotao is right: the smc91x driver support for it is broken.

I have one here on an ISA board (and it took me a long time to find
working PC
hardware old enough to use this!). I'll send a patch when I can find time
to
fix it, but until then I agree this broken code should be removed.

Acked-by: Steve Glendinning <steve.glendinning@smsc.com>

--
Steve Glendinning
SMSC GmbH
m: +44 777 933 9124
e: steve.glendinning@smsc.com