From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, cl@linux-foundation.org,
mingo@elte.hu, akpm@linux-foundation.org,
manfred@colorfullife.com, dipankar@in.ibm.com,
josht@linux.vnet.ibm.com, schamp@sgi.com, niv@us.ibm.com,
dvhltc@us.ibm.com, ego@in.ibm.com, laijs@cn.fujitsu.com,
rostedt@goodmis.org, peterz@infradead.org,
penberg@cs.helsinki.fi, tglx@linutronix.de
Subject: Re: [PATCH -tip] v9 scalable classic RCU implementation
Date: Tue, 2 Dec 2008 16:47:59 -0800 [thread overview]
Message-ID: <20081203004759.GG6719@linux.vnet.ibm.com> (raw)
In-Reply-To: <20081203001811.GF6703@one.firstfloor.org>
On Wed, Dec 03, 2008 at 01:18:12AM +0100, Andi Kleen wrote:
> On Tue, Dec 02, 2008 at 03:51:45PM -0800, Paul E. McKenney wrote:
> > On Wed, Dec 03, 2008 at 12:31:44AM +0100, Andi Kleen wrote:
> > > > o I now test with a more brutal random-selection online/offline
> > > > script (attached). Probably more brutal than it needs to be
> > > > on the people reading it as well, but so it goes.
> > >
> > > Does that cover both dynticks on and off? afaik the dynticks off problem
> > > I ran into on a 16 thread box and we discussed some time ago is still there.
> >
> > The failures I see with this patch I also see with mainline. Are you
> > seeing something with this patch that does not happen with mainline?
>
> No, that is in mainline too. Sorry to be misleading. Do you see the
> same problems in your testing?
On Power, I see a hang in all three flavors of RCU when CPU hotplug
is enabled and dynticks is not. I have not yet seen this hang on x86.
On Power, the hang occurs in the CPU-offline code, and is identical to
the hangs I was seeing in 2.6.27, except that "sleep 1" does not hang
in recent 2.6.28 versions. So the timeout is apparently failing to fire
(or being ignored) for some other reason.
Is this similar to what you are seeing on x86?
I am currently undergoing a line-by-line code walkthrough of rcutree on
the off-chance that all three versions of RCU suffer from the same bug.
(And I have found a few bugs and spelling errors, but nothing related
to the problem at hand.) If I don't find anything, I will start looking
more closely at the CPU-hotplug code.
Thanx, Paul
next prev parent reply other threads:[~2008-12-03 0:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 22:21 [PATCH -tip] v9 scalable classic RCU implementation Paul E. McKenney
2008-12-02 23:31 ` Andi Kleen
2008-12-02 23:51 ` Paul E. McKenney
2008-12-03 0:18 ` Andi Kleen
2008-12-03 0:47 ` Paul E. McKenney [this message]
2008-12-03 1:10 ` Andi Kleen
2008-12-03 1:36 ` Paul E. McKenney
2008-12-18 22:54 ` Paul E. McKenney
2008-12-19 1:29 ` Andi Kleen
2008-12-19 1:49 ` Paul E. McKenney
2008-12-03 8:40 ` Ingo Molnar
2008-12-17 0:37 ` [PATCH -tip] v10 " Paul E. McKenney
2008-12-17 2:03 ` Andrew Morton
2008-12-17 19:49 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081203004759.GG6719@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=ego@in.ibm.com \
--cc=josht@linux.vnet.ibm.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=schamp@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox