From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu, fweisbec@gmail.com,
srostedt@redhat.com
Subject: Re: [PATCH 3/5] ring-buffer: read page interface
Date: Wed, 3 Dec 2008 09:39:29 +1030 [thread overview]
Message-ID: <200812030939.29907.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20081202133654.2dfa51cd.akpm@linux-foundation.org>
On Wednesday 03 December 2008 08:06:54 Andrew Morton wrote:
> Steven Rostedt <rostedt@goodmis.org> wrote:
> > + if (!local_read(&cpu_buffer->reader_page->page->commit))
>
> Rusty (I think it was Rusty) has convincingly argued that local_t is
> irredeemably busted. I forget the details?
That was probably Christoph Lameter. The x86 implementation needs some love,
but the API seems reasonable.
On x86-32, the cpu_local_inc should be (as intended) turned into one insn.
That would be possible on 64 bit once we get zero-based percpu (as will World
Peace).
Cheers,
Rusty.
next prev parent reply other threads:[~2008-12-02 23:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 20:34 [PATCH 0/5] ftrace updates for tip Steven Rostedt
2008-12-02 20:34 ` [PATCH 1/5] ftrace: replace raw_local_irq_save with local_irq_save Steven Rostedt
2008-12-03 9:21 ` Wang Liming
2008-12-02 20:34 ` [PATCH 2/5] ring-buffer: move some metadata into buffer page Steven Rostedt
2008-12-02 20:34 ` [PATCH 3/5] ring-buffer: read page interface Steven Rostedt
2008-12-02 21:36 ` Andrew Morton
2008-12-02 22:25 ` Steven Rostedt
2008-12-02 23:09 ` Rusty Russell [this message]
2008-12-02 20:34 ` [PATCH 4/5] ftrace: clean up function graph asm Steven Rostedt
2008-12-02 21:24 ` Frédéric Weisbecker
2008-12-02 20:34 ` [PATCH 5/5] ftrace: have function graph use mcount caller address Steven Rostedt
2008-12-03 7:57 ` [PATCH 0/5] ftrace updates for tip Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812030939.29907.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox