From: Stephen Hemminger <shemminger@vyatta.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-kernel@vger.kernel.org,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
Alexander Beregalov <a.beregalov@gmail.com>
Subject: Re: [PATCH 1/4] dmaengine: add a release for dma class devices and dependent infrastructure
Date: Wed, 3 Dec 2008 17:07:41 -0800 [thread overview]
Message-ID: <20081203170741.7f25d756@extreme> (raw)
In-Reply-To: <20081204004646.27790.70015.stgit@dwillia2-linux.ch.intel.com>
On Wed, 03 Dec 2008 17:46:46 -0700
Dan Williams <dan.j.williams@intel.com> wrote:
> Resolves:
> WARNING: at drivers/base/core.c:122 device_release+0x4d/0x52()
> Device 'dma0chan0' does not have a release() function, it is broken and must be fixed.
>
> The dma_chan_dev object is introduced to gear-match sysfs kobject and
> dmaengine channel lifetimes. When a channel is removed access to the
> sysfs entries return -ENODEV until the kobject can be released.
>
> The bulk of the change is updates to existing code to handle the extra
> layer of indirection between a dma_chan and its struct device.
>
> Reported-by: Alexander Beregalov <a.beregalov@gmail.com>
> Cc: Stephen Hemminger <shemminger@vyatta.com>
> Cc: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Much better thanks.
next prev parent reply other threads:[~2008-12-04 1:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 0:46 [PATCH 0/4] dmaengine redux continued Dan Williams
2008-12-04 0:46 ` [PATCH 1/4] dmaengine: add a release for dma class devices and dependent infrastructure Dan Williams
2008-12-04 1:07 ` Stephen Hemminger [this message]
2008-12-04 0:46 ` [PATCH 2/4] dmaengine: use idr for registering dma device numbers Dan Williams
2008-12-04 0:46 ` [PATCH 3/4] dmaengine: advertise all channels on a device to dma_filter_fn Dan Williams
2008-12-04 0:47 ` [PATCH 4/4] dmaengine: bump initcall level to arch_initcall Dan Williams
2008-12-04 8:51 ` [PATCH 0/4] dmaengine redux continued Guennadi Liakhovetski
2008-12-04 18:52 ` Dan Williams
2008-12-04 20:03 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081203170741.7f25d756@extreme \
--to=shemminger@vyatta.com \
--cc=a.beregalov@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox