Re: [patch 016/104] epoll: introduce resource usage limits

Davide Libenzi
2009-01-28T03:46:30Z

On Wed, 28 Jan 2009, Bron Gondwana wrote:

> On Tue, Jan 27, 2009 at 04:35:19PM -0800, Greg KH wrote:
> > Can you resubmit all 4 patches, and cc: the epoll author, Davide? He's
> > the one that needs to accept these changes.
>
> It's three now (two of them deserved to merged) and re-ordered so the
> first two are trivial and the complex bits are easily skipped if you
> don't want them.
>
> Just looking for Davide's email address. Found it :) I'll follow up
> this message with the patches. I'm not going to CC everyone else again
> - but I'll CC LKML so you can follow it there if you want.

I already gave you my opinion on such code. There is no need for it. If
your servers are loaded, in the same way you bump NFILES (and likely
even other default configs), you bump up max_user_instances:

$ echo NN > /proc/sys/fs/epoll/max_user_instances

It requires no extra crud in the kernel, and it works pretty darn good.

- Davide