Re: [patch 101/104] ext3: dont try to resize if there are no reserved gdt blocks left

Valdis.Kletnieks
2008-12-04T22:11:03Z

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

On Wed, 03 Dec 2008 11:56:53 PST, Greg KH said:

> if (reserved_gdb || gdb_off == 0) {
> if (!EXT3_HAS_COMPAT_FEATURE(sb,
> - EXT3_FEATURE_COMPAT_RESIZE_INODE))
{
> + EXT3_FEATURE_COMPAT_RESIZE_INODE)
> + || !le16_to_cpu(es->s_reserved_gdt_blocks)) {
> ext3_warning(sb, __func__,
> "No reserved GDT blocks, can't resize");
> return -EPERM;

What's the codepath if the compat_feature part trips, but the le16_to_cpu
doesn't? Looks to me like it will then skip over the 'return -EPERM'?

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]