public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Greg K-H <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] DEBUG_KOBJECT vs. DYNAMIC_PRINTK_DEBUG
Date: Wed, 3 Dec 2008 15:12:03 -0500	[thread overview]
Message-ID: <20081203201203.GA3128@redhat.com> (raw)
In-Reply-To: <20081202145251.6555d4cc@gondolin>

On Tue, Dec 02, 2008 at 02:52:51PM +0100, Cornelia Huck wrote:
> DEBUG_KOBJECT has no effect when DYNAMIC_PRINTK_DEBUG is set
> (and you can get the messages via that feature), so let's make
> it depend on !DYNAMIC_PRINTK_DEBUG.
> 

indeed. you raise the more general question of what do if both 'DEBUG'
and 'CONFIG_DYNAMIC_PRINTK_DEBUG' are set for a file? I think that in
general the 'DEBUG' should take precedence, as you point out. However, I
think we should fix this by reshuffling the logic in
include/linux/kernel.h by doing:

if (DEBUG)
	#define pr_debug printk
elseif (CONFIG_DYNAMIC_PRINTK_DEBUG)
	#define pr_debug dynamic_pr_debug()
else
	#define pr_debug if (0) blah:
endif

make sense? what do you think?

thanks,

-Jason

  reply	other threads:[~2008-12-03 20:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-02 13:52 [PATCH] DEBUG_KOBJECT vs. DYNAMIC_PRINTK_DEBUG Cornelia Huck
2008-12-03 20:12 ` Jason Baron [this message]
2008-12-04 12:48   ` Cornelia Huck
2008-12-04 12:51     ` [PATCH] Make DEBUG take precedence over DYNAMIC_PRINTK_DEBUG Cornelia Huck
2008-12-04 14:42       ` Jason Baron
2008-12-04 15:55         ` [PATCH] Make DEBUG take precedence over DYNAMIC_PRINTK_DEBUG (v2) Cornelia Huck
2008-12-04 16:44           ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081203201203.GA3128@redhat.com \
    --to=jbaron@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox