From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
containers@lists.osdl.org, Eric Biederman <ebiederm@xmission.com>,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
"Serge E. Hallyn" <serue@us.ibm.com>,
Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 3/3] ftrace: add ability to only trace swapper tasks
Date: Thu, 04 Dec 2008 00:26:41 -0500 [thread overview]
Message-ID: <20081204052735.362609481@goodmis.org> (raw)
In-Reply-To: 20081204052638.425740534@goodmis.org
[-- Attachment #1: 0003-ftrace-add-ability-to-only-trace-swapper-tasks.patch --]
[-- Type: text/plain, Size: 3369 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
Impact: New feature
This patch lets the swapper tasks of all CPUS be filtered by the
set_ftrace_pid file.
If '0' is echoed into this file, then all the idle tasks (aka swapper)
is flagged to be traced. This affects all CPU idle tasks.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/trace/ftrace.c | 74 +++++++++++++++++++++++++++++++++++++++++-------
1 files changed, 63 insertions(+), 11 deletions(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 10b1d7c..eb57dc1 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -49,6 +49,7 @@ static int last_ftrace_enabled;
/* set when tracing only a pid */
struct pid *ftrace_pid_trace;
+static struct pid * const ftrace_swapper_pid = (struct pid *)1;
/* Quick disabling of function tracer. */
int function_trace_stop;
@@ -1678,7 +1679,9 @@ ftrace_pid_read(struct file *file, char __user *ubuf,
char buf[64];
int r;
- if (ftrace_pid_trace)
+ if (ftrace_pid_trace == ftrace_swapper_pid)
+ r = sprintf(buf, "swapper tasks\n");
+ else if (ftrace_pid_trace)
r = sprintf(buf, "%u\n", pid_nr(ftrace_pid_trace));
else
r = sprintf(buf, "no pid\n");
@@ -1686,19 +1689,43 @@ ftrace_pid_read(struct file *file, char __user *ubuf,
return simple_read_from_buffer(ubuf, cnt, ppos, buf, r);
}
-static void clear_ftrace_pid_task(struct pid **pid)
+static void clear_ftrace_swapper(void)
{
struct task_struct *p;
+ int cpu;
- do_each_pid_task(*pid, PIDTYPE_PID, p) {
+ get_online_cpus();
+ for_each_online_cpu(cpu) {
+ p = idle_task(cpu);
clear_tsk_trace_trace(p);
- } while_each_pid_task(*pid, PIDTYPE_PID, p);
- put_pid(*pid);
+ }
+ put_online_cpus();
+}
- *pid = NULL;
+static void set_ftrace_swapper(void)
+{
+ struct task_struct *p;
+ int cpu;
+
+ get_online_cpus();
+ for_each_online_cpu(cpu) {
+ p = idle_task(cpu);
+ set_tsk_trace_trace(p);
+ }
+ put_online_cpus();
}
-static void set_ftrace_pid_task(struct pid *pid)
+static void clear_ftrace_pid(struct pid *pid)
+{
+ struct task_struct *p;
+
+ do_each_pid_task(pid, PIDTYPE_PID, p) {
+ clear_tsk_trace_trace(p);
+ } while_each_pid_task(pid, PIDTYPE_PID, p);
+ put_pid(pid);
+}
+
+static void set_ftrace_pid(struct pid *pid)
{
struct task_struct *p;
@@ -1707,6 +1734,24 @@ static void set_ftrace_pid_task(struct pid *pid)
} while_each_pid_task(pid, PIDTYPE_PID, p);
}
+static void clear_ftrace_pid_task(struct pid **pid)
+{
+ if (*pid == ftrace_swapper_pid)
+ clear_ftrace_swapper();
+ else
+ clear_ftrace_pid(*pid);
+
+ *pid = NULL;
+}
+
+static void set_ftrace_pid_task(struct pid *pid)
+{
+ if (pid == ftrace_swapper_pid)
+ set_ftrace_swapper();
+ else
+ set_ftrace_pid(pid);
+}
+
static ssize_t
ftrace_pid_write(struct file *filp, const char __user *ubuf,
size_t cnt, loff_t *ppos)
@@ -1737,11 +1782,18 @@ ftrace_pid_write(struct file *filp, const char __user *ubuf,
clear_ftrace_pid_task(&ftrace_pid_trace);
} else {
- pid = find_get_pid(val);
+ /* swapper task is special */
+ if (!val) {
+ pid = ftrace_swapper_pid;
+ if (pid == ftrace_pid_trace)
+ goto out;
+ } else {
+ pid = find_get_pid(val);
- if (pid == ftrace_pid_trace) {
- put_pid(pid);
- goto out;
+ if (pid == ftrace_pid_trace) {
+ put_pid(pid);
+ goto out;
+ }
}
if (ftrace_pid_trace)
--
1.5.6.5
--
next prev parent reply other threads:[~2008-12-04 5:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 5:26 [PATCH 0/3] ftrace: clean ups for tip Steven Rostedt
2008-12-04 5:26 ` [PATCH 1/3] fix the do_each_pid_task macro Steven Rostedt
2008-12-04 5:26 ` [PATCH 2/3] ftrace: use struct pid Steven Rostedt
2008-12-04 12:42 ` Eric W. Biederman
2008-12-04 12:56 ` Dave Hansen
2008-12-04 13:07 ` Dave Hansen
2008-12-04 13:40 ` Eric W. Biederman
2008-12-04 15:12 ` Dave Hansen
2008-12-04 15:35 ` Steven Rostedt
2008-12-04 15:41 ` Dave Hansen
2008-12-04 15:44 ` Steven Rostedt
2008-12-04 14:29 ` Steven Rostedt
2008-12-05 3:17 ` Dipankar Sarma
2008-12-04 12:55 ` Eric W. Biederman
2008-12-04 14:23 ` Steven Rostedt
2008-12-04 14:32 ` Eric W. Biederman
2008-12-04 16:22 ` Sukadev Bhattiprolu
2008-12-04 5:26 ` Steven Rostedt [this message]
2008-12-04 5:34 ` [PATCH 3/3] ftrace: add ability to only trace swapper tasks Wang Liming
2008-12-04 5:50 ` Wang Liming
2008-12-04 8:06 ` Ingo Molnar
2008-12-04 8:18 ` Andrew Morton
2008-12-04 9:10 ` Ingo Molnar
2008-12-04 12:59 ` Eric W. Biederman
2008-12-04 14:46 ` Steven Rostedt
2008-12-04 20:41 ` Eric W. Biederman
2008-12-04 20:57 ` Steven Rostedt
2008-12-04 21:43 ` Eric W. Biederman
2008-12-04 21:56 ` Steven Rostedt
2008-12-05 7:43 ` Eric W. Biederman
2008-12-05 12:23 ` Steven Rostedt
2008-12-05 16:35 ` Eric W. Biederman
2008-12-05 4:30 ` [PATCH] ftrace: use init_struct_pid as swapper pid Steven Rostedt
2008-12-05 13:51 ` Ingo Molnar
2008-12-04 15:36 ` [PATCH 3/3] ftrace: add ability to only trace swapper tasks Ingo Molnar
2008-12-04 15:47 ` Steven Rostedt
2008-12-04 13:12 ` Steven Rostedt
2008-12-04 13:52 ` Eric W. Biederman
2008-12-04 12:54 ` Eric W. Biederman
2008-12-04 14:57 ` Steven Rostedt
2008-12-04 8:10 ` [PATCH 0/3] ftrace: clean ups for tip Ingo Molnar
2008-12-04 8:30 ` [PATCH] tracing: fix typo Ingo Molnar
2008-12-04 8:34 ` [PATCH] tracing: fix typo and missing inline function Ingo Molnar
2008-12-04 13:16 ` Steven Rostedt
2008-12-04 15:35 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204052735.362609481@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=dave@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=serue@us.ibm.com \
--cc=srostedt@redhat.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox