From: Jens Axboe <jens.axboe@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: use min_not_zero in blk_queue_stack_limits
Date: Thu, 4 Dec 2008 08:56:07 +0100 [thread overview]
Message-ID: <20081204075607.GG18255@kernel.dk> (raw)
In-Reply-To: <20081204153243G.fujita.tomonori@lab.ntt.co.jp>
On Thu, Dec 04 2008, FUJITA Tomonori wrote:
> This is against for-2.6.29 in the block tree.
> =
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Subject: [PATCH] block: use min_not_zero in blk_queue_stack_limits
>
> zero is invalid for max_phys_segments, max_hw_segments, and
> max_segment_size. It's better to use use min_not_zero instead of
> min. min() works though (because the commit 0e435ac makes sure that
> these values are set to the default values, non zero, if a queue is
> initialized properly).
>
> With this patch, blk_queue_stack_limits does the almost same thing
> that dm's combine_restrictions_low() does. I think that it's easy to
> remove dm's combine_restrictions_low.
Queued up for 2.6.29. It would be nice to get rid of the dm mirror of
this function...
--
Jens Axboe
prev parent reply other threads:[~2008-12-04 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 6:32 [PATCH] block: use min_not_zero in blk_queue_stack_limits FUJITA Tomonori
2008-12-04 7:56 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204075607.GG18255@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox