From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Arjan van de Ven <arjan@infradead.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
containers@lists.osdl.org, Eric Biederman <ebiederm@xmission.com>,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
"Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [PATCH 0/3] ftrace: updates for tip
Date: Thu, 4 Dec 2008 09:19:27 +0100 [thread overview]
Message-ID: <20081204081927.GD32594@elte.hu> (raw)
In-Reply-To: <20081203203656.776893226@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> Ingo,
>
> This series has three patches.
>
> The first patch adds a new feature that I've been wanting to have for some
> time and Arjan even requested. That is to pick a function and only
> trace that function and its children. Dynamic ftrace and function
> graph needs to be enabled for this.
>
> To do the above, I added a "trace" flags field in the task structure.
> The second patch uses this for the ftrace pid code. It searches for
> the task based on the pid and sets the trace flag, then in the
> ftrace function caller it only needs to check this flag.
>
> This means we can now trace more than one pid without any more overhead.
> It also means that we should be able to use the name space code that
> the container guys want us to. But since I'm not very up on the
> namespace code, I'm still using just the normal 'pid'. I've Cc'd the
> container folks so perhaps they could write up a patch for me ;-)
>
> Note: When writing to the set_ftrace_pid two things happen.
> - The task with the matching pid gets the trace flag set.
> - Any other task has its trace flag cleared.
> #2 needs to be addressed when converting to pid name spaces.
> Just because it is not enough to simply find the matching task.
> It may be good enough to just clear all tasks and then find the
> one that matches.
>
> The last patch makes the function graph tracer honor the set_ftrace_pid.
>
> The following patches are in:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
>
> branch: tip/devel
>
>
> Steven Rostedt (3):
> ftrace: graph of a single function
> ftrace: use task struct trace flag to filter on pid
> ftrace: trace single pid for function graph tracer
>
> ----
> include/linux/ftrace.h | 46 +++++++++
> include/linux/sched.h | 4 +
> kernel/trace/ftrace.c | 257 +++++++++++++++++++++++++++++++++++++++++++++++-
> kernel/trace/trace.c | 11 ++
> kernel/trace/trace.h | 40 +++++++-
> 5 files changed, 353 insertions(+), 5 deletions(-)
> --
pulled, thanks Steve!
These are some very nice changes!
Ingo
next prev parent reply other threads:[~2008-12-04 8:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 20:36 [PATCH 0/3] ftrace: updates for tip Steven Rostedt
2008-12-03 20:36 ` [PATCH 1/3] ftrace: graph of a single function Steven Rostedt
2008-12-03 21:07 ` Andrew Morton
2008-12-03 21:10 ` Steven Rostedt
2008-12-03 21:32 ` Andrew Morton
2008-12-03 21:36 ` Steven Rostedt
2008-12-04 8:39 ` Ingo Molnar
2008-12-03 21:08 ` Andrew Morton
2008-12-03 21:11 ` Steven Rostedt
2008-12-04 8:41 ` Ingo Molnar
2008-12-04 8:43 ` Peter Zijlstra
2008-12-15 9:21 ` Andy Whitcroft
2008-12-04 6:24 ` [PATCH 1/1] ftrace: avoid duplicated function when writing set_graph_function Liming Wang
2008-12-04 8:42 ` Ingo Molnar
2008-12-03 20:36 ` [PATCH 2/3] ftrace: use task struct trace flag to filter on pid Steven Rostedt
2008-12-03 22:34 ` Eric W. Biederman
2008-12-03 20:36 ` [PATCH 3/3] ftrace: trace single pid for function graph tracer Steven Rostedt
2008-12-03 20:49 ` Andrew Morton
2008-12-03 20:52 ` Steven Rostedt
2008-12-03 23:36 ` Eric W. Biederman
2008-12-04 2:29 ` Steven Rostedt
2008-12-04 4:22 ` Eric W. Biederman
2008-12-04 4:32 ` Steven Rostedt
2008-12-04 8:19 ` Ingo Molnar [this message]
2008-12-04 8:35 ` [PATCH 0/3] ftrace: updates for tip Ingo Molnar
2008-12-04 13:30 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2009-02-05 6:13 Steven Rostedt
2009-02-05 13:37 ` Ingo Molnar
2009-02-03 2:38 Steven Rostedt
2008-12-24 4:24 Steven Rostedt
2008-12-24 23:13 ` Frederic Weisbecker
2008-12-24 23:24 ` Frederic Weisbecker
2008-12-29 11:46 ` Ingo Molnar
2008-11-15 0:45 Steven Rostedt
2008-11-12 22:52 [PATCH 0/3] ftrace " Steven Rostedt
2008-11-13 8:50 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204081927.GD32594@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=containers@lists.osdl.org \
--cc=dave@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=serue@us.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox