From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>, Andy Whitcroft <apw@shadowen.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, fweisbec@gmail.com,
peterz@infradead.org, arjan@infradead.org,
dave@linux.vnet.ibm.com, containers@lists.osdl.org,
ebiederm@xmission.com, sukadev@linux.vnet.ibm.com,
serue@us.ibm.com, srostedt@redhat.com
Subject: Re: [PATCH 1/3] ftrace: graph of a single function
Date: Thu, 4 Dec 2008 09:41:18 +0100 [thread overview]
Message-ID: <20081204084118.GG32594@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0812031611000.29045@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Wed, 3 Dec 2008, Andrew Morton wrote:
>
> > On Wed, 03 Dec 2008 15:36:57 -0500
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > +static struct seq_operations ftrace_graph_seq_ops = {
> > > + .start = g_start,
> > > + .next = g_next,
> > > + .stop = g_stop,
> > > + .show = g_show,
> > > +};
> >
> > This could be static I think.
>
> s/static/const/
>
> Damn damn damn damn!!!! I said to myself, I need to add const there and
> still forgot :-(
No need to get stressed up about such details - we need checkpatch help
for this.
Ingo
next prev parent reply other threads:[~2008-12-04 8:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 20:36 [PATCH 0/3] ftrace: updates for tip Steven Rostedt
2008-12-03 20:36 ` [PATCH 1/3] ftrace: graph of a single function Steven Rostedt
2008-12-03 21:07 ` Andrew Morton
2008-12-03 21:10 ` Steven Rostedt
2008-12-03 21:32 ` Andrew Morton
2008-12-03 21:36 ` Steven Rostedt
2008-12-04 8:39 ` Ingo Molnar
2008-12-03 21:08 ` Andrew Morton
2008-12-03 21:11 ` Steven Rostedt
2008-12-04 8:41 ` Ingo Molnar [this message]
2008-12-04 8:43 ` Peter Zijlstra
2008-12-15 9:21 ` Andy Whitcroft
2008-12-04 6:24 ` [PATCH 1/1] ftrace: avoid duplicated function when writing set_graph_function Liming Wang
2008-12-04 8:42 ` Ingo Molnar
2008-12-03 20:36 ` [PATCH 2/3] ftrace: use task struct trace flag to filter on pid Steven Rostedt
2008-12-03 22:34 ` Eric W. Biederman
2008-12-03 20:36 ` [PATCH 3/3] ftrace: trace single pid for function graph tracer Steven Rostedt
2008-12-03 20:49 ` Andrew Morton
2008-12-03 20:52 ` Steven Rostedt
2008-12-03 23:36 ` Eric W. Biederman
2008-12-04 2:29 ` Steven Rostedt
2008-12-04 4:22 ` Eric W. Biederman
2008-12-04 4:32 ` Steven Rostedt
2008-12-04 8:19 ` [PATCH 0/3] ftrace: updates for tip Ingo Molnar
2008-12-04 8:35 ` Ingo Molnar
2008-12-04 13:30 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204084118.GG32594@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=arjan@infradead.org \
--cc=containers@lists.osdl.org \
--cc=dave@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=serue@us.ibm.com \
--cc=srostedt@redhat.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox