From: Andi Kleen <andi@firstfloor.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Jack Steiner <steiner@sgi.com>, Yinghai Lu <yinghai@kernel.org>
Subject: Re: 2.6.28-rc6: early panic with boot option "nosmp"
Date: Thu, 4 Dec 2008 13:33:35 +0100 [thread overview]
Message-ID: <20081204123335.GP6703@one.firstfloor.org> (raw)
In-Reply-To: <20081204120214.GA30833@localhost>
> The exception raised on dereferencing mpf or mpf_found.
This obvious patch should fix it then. Does it?
--
Fix early exception in __get_smp_config with nosmp
Bail out early when there is no MP table.
Reported by Wu Fengguang
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
arch/x86/kernel/mpparse.c | 3 +++
1 file changed, 3 insertions(+)
Index: linux-2.6.28-rc4-test/arch/x86/kernel/mpparse.c
===================================================================
--- linux-2.6.28-rc4-test.orig/arch/x86/kernel/mpparse.c 2008-10-24 13:34:40.000000000 +0200
+++ linux-2.6.28-rc4-test/arch/x86/kernel/mpparse.c 2008-12-04 13:20:34.000000000 +0100
@@ -604,6 +604,9 @@
printk(KERN_INFO "Using ACPI for processor (LAPIC) "
"configuration information\n");
+ if (!mpf)
+ return;
+
printk(KERN_INFO "Intel MultiProcessor Specification v1.%d\n",
mpf->mpf_specification);
#if defined(CONFIG_X86_LOCAL_APIC) && defined(CONFIG_X86_32)
next prev parent reply other threads:[~2008-12-04 12:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 2:28 2.6.28-rc6: early panic with boot option "nosmp" Wu Fengguang
2008-12-04 8:10 ` Wu Fengguang
2008-12-04 10:13 ` Andi Kleen
2008-12-04 12:02 ` Wu Fengguang
2008-12-04 12:06 ` Wu Fengguang
2008-12-04 12:33 ` Andi Kleen [this message]
2008-12-04 12:28 ` Wu Fengguang
2008-12-04 15:34 ` Ingo Molnar
2008-12-04 21:08 ` Yinghai Lu
2008-12-04 22:09 ` Andi Kleen
2008-12-04 22:20 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204123335.GP6703@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox