From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Jason Baron <jbaron@redhat.com>
Cc: Greg K-H <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] DEBUG_KOBJECT vs. DYNAMIC_PRINTK_DEBUG
Date: Thu, 4 Dec 2008 13:48:45 +0100 [thread overview]
Message-ID: <20081204134845.6c1df66b@gondolin> (raw)
In-Reply-To: <20081203201203.GA3128@redhat.com>
On Wed, 3 Dec 2008 15:12:03 -0500,
Jason Baron <jbaron@redhat.com> wrote:
> indeed. you raise the more general question of what do if both 'DEBUG'
> and 'CONFIG_DYNAMIC_PRINTK_DEBUG' are set for a file? I think that in
> general the 'DEBUG' should take precedence, as you point out. However, I
> think we should fix this by reshuffling the logic in
> include/linux/kernel.h by doing:
>
> if (DEBUG)
> #define pr_debug printk
> elseif (CONFIG_DYNAMIC_PRINTK_DEBUG)
> #define pr_debug dynamic_pr_debug()
> else
> #define pr_debug if (0) blah:
> endif
>
> make sense? what do you think?
Yes, that makes sense, I agree. I'll follow up with a patch.
next prev parent reply other threads:[~2008-12-04 12:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 13:52 [PATCH] DEBUG_KOBJECT vs. DYNAMIC_PRINTK_DEBUG Cornelia Huck
2008-12-03 20:12 ` Jason Baron
2008-12-04 12:48 ` Cornelia Huck [this message]
2008-12-04 12:51 ` [PATCH] Make DEBUG take precedence over DYNAMIC_PRINTK_DEBUG Cornelia Huck
2008-12-04 14:42 ` Jason Baron
2008-12-04 15:55 ` [PATCH] Make DEBUG take precedence over DYNAMIC_PRINTK_DEBUG (v2) Cornelia Huck
2008-12-04 16:44 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204134845.6c1df66b@gondolin \
--to=cornelia.huck@de.ibm.com \
--cc=greg@kroah.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox