public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	containers@lists.osdl.org, Eric Biederman <ebiederm@xmission.com>,
	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	"Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [PATCH] tracing: fix typo and missing inline function
Date: Thu, 4 Dec 2008 16:35:24 +0100	[thread overview]
Message-ID: <20081204153524.GA18293@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0812040815350.5240@gandalf.stny.rr.com>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> 
> On Thu, 4 Dec 2008, Ingo Molnar wrote:
> 
> > 
> > * Ingo Molnar <mingo@elte.hu> wrote:
> > 
> > > small fixlet below.
> > 
> > updated.
> > 
> > --------------->
> > >From 6b2539302bee8e88c99e3c7d80c16a04dbe5e2ad Mon Sep 17 00:00:00 2001
> > From: Ingo Molnar <mingo@elte.hu>
> > Date: Thu, 4 Dec 2008 09:18:28 +0100
> > Subject: [PATCH] tracing: fix typo and missing inline function
> > 
> > Impact: fix build bugs
> > 
> > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > ---
> >  kernel/trace/trace.h |    6 +++++-
> >  1 files changed, 5 insertions(+), 1 deletions(-)
> > 
> > diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> > index 8b81b4d..b4b7b73 100644
> > --- a/kernel/trace/trace.h
> > +++ b/kernel/trace/trace.h
> > @@ -529,7 +529,11 @@ static inline int ftrace_graph_addr(unsigned long addr)
> >  #else
> >  static inline int ftrace_trace_addr(unsigned long addr)
> >  {
> > -	return 1
> > +	return 1;
> > +}
> > +static inline int ftrace_graph_addr(unsigned long addr)
> > +{
> > +	return 1;
> >  }
> >  #endif /* CONFIG_DYNAMIC_FTRACE */
> 
> Thanks! I guess I need to test the "off" cases ;-)

As long as we are free of runtime bugs, we'll be just fine ;-)

	Ingo

      reply	other threads:[~2008-12-04 15:36 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04  5:26 [PATCH 0/3] ftrace: clean ups for tip Steven Rostedt
2008-12-04  5:26 ` [PATCH 1/3] fix the do_each_pid_task macro Steven Rostedt
2008-12-04  5:26 ` [PATCH 2/3] ftrace: use struct pid Steven Rostedt
2008-12-04 12:42   ` Eric W. Biederman
2008-12-04 12:56     ` Dave Hansen
2008-12-04 13:07       ` Dave Hansen
2008-12-04 13:40         ` Eric W. Biederman
2008-12-04 15:12           ` Dave Hansen
2008-12-04 15:35             ` Steven Rostedt
2008-12-04 15:41           ` Dave Hansen
2008-12-04 15:44             ` Steven Rostedt
2008-12-04 14:29         ` Steven Rostedt
2008-12-05  3:17         ` Dipankar Sarma
2008-12-04 12:55   ` Eric W. Biederman
2008-12-04 14:23     ` Steven Rostedt
2008-12-04 14:32       ` Eric W. Biederman
2008-12-04 16:22         ` Sukadev Bhattiprolu
2008-12-04  5:26 ` [PATCH 3/3] ftrace: add ability to only trace swapper tasks Steven Rostedt
2008-12-04  5:34   ` Wang Liming
2008-12-04  5:50     ` Wang Liming
2008-12-04  8:06   ` Ingo Molnar
2008-12-04  8:18   ` Andrew Morton
2008-12-04  9:10     ` Ingo Molnar
2008-12-04 12:59       ` Eric W. Biederman
2008-12-04 14:46         ` Steven Rostedt
2008-12-04 20:41           ` Eric W. Biederman
2008-12-04 20:57             ` Steven Rostedt
2008-12-04 21:43               ` Eric W. Biederman
2008-12-04 21:56                 ` Steven Rostedt
2008-12-05  7:43                   ` Eric W. Biederman
2008-12-05 12:23                     ` Steven Rostedt
2008-12-05 16:35                       ` Eric W. Biederman
2008-12-05  4:30                 ` [PATCH] ftrace: use init_struct_pid as swapper pid Steven Rostedt
2008-12-05 13:51                   ` Ingo Molnar
2008-12-04 15:36         ` [PATCH 3/3] ftrace: add ability to only trace swapper tasks Ingo Molnar
2008-12-04 15:47           ` Steven Rostedt
2008-12-04 13:12     ` Steven Rostedt
2008-12-04 13:52       ` Eric W. Biederman
2008-12-04 12:54   ` Eric W. Biederman
2008-12-04 14:57     ` Steven Rostedt
2008-12-04  8:10 ` [PATCH 0/3] ftrace: clean ups for tip Ingo Molnar
2008-12-04  8:30   ` [PATCH] tracing: fix typo Ingo Molnar
2008-12-04  8:34     ` [PATCH] tracing: fix typo and missing inline function Ingo Molnar
2008-12-04 13:16       ` Steven Rostedt
2008-12-04 15:35         ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081204153524.GA18293@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.osdl.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=serue@us.ibm.com \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox