From: "K.Prasad" <prasad@linux.vnet.ibm.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Roland McGrath <roland@redhat.com>,
akpm@linux-foundation.org, mingo@elte.hu,
richardj_moore@uk.ibm.com
Subject: [RFC Patch 5/9] Use wrapper routines around debug registers in processor related functions
Date: Fri, 5 Dec 2008 00:43:25 +0530 [thread overview]
Message-ID: <20081204191325.GE20563@in.ibm.com> (raw)
In-Reply-To: <20081204190804.GA15134@in.ibm.com>
This patch enables the use of wrapper routines to access the debug/breakpoint
registers.
Signed-off-by: K.Prasad <prasad@linux.vnet.ibm.com>
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
---
arch/x86/kernel/smpboot.c | 3 +++
arch/x86/power/cpu_32.c | 16 +++-------------
arch/x86/power/cpu_64.c | 15 +++------------
3 files changed, 9 insertions(+), 25 deletions(-)
Index: linux-2.6.28-rc5-bkpt-latest/arch/x86/power/cpu_32.c
===================================================================
--- linux-2.6.28-rc5-bkpt-latest.orig/arch/x86/power/cpu_32.c
+++ linux-2.6.28-rc5-bkpt-latest/arch/x86/power/cpu_32.c
@@ -12,6 +12,7 @@
#include <asm/mtrr.h>
#include <asm/mce.h>
#include <asm/xcr.h>
+#include <asm/debugreg.h>
static struct saved_context saved_context;
@@ -47,6 +48,7 @@ static void __save_processor_state(struc
ctxt->cr2 = read_cr2();
ctxt->cr3 = read_cr3();
ctxt->cr4 = read_cr4_safe();
+ disable_debug_registers();
}
/* Needed by apm.c */
@@ -79,19 +81,7 @@ static void fix_processor_context(void)
load_TR_desc(); /* This does ltr */
load_LDT(¤t->active_mm->context); /* This does lldt */
- /*
- * Now maybe reload the debug registers
- */
- if (current->thread.debugreg7) {
- set_debugreg(current->thread.debugreg0, 0);
- set_debugreg(current->thread.debugreg1, 1);
- set_debugreg(current->thread.debugreg2, 2);
- set_debugreg(current->thread.debugreg3, 3);
- /* no 4 and 5 */
- set_debugreg(current->thread.debugreg6, 6);
- set_debugreg(current->thread.debugreg7, 7);
- }
-
+ load_debug_registers();
}
static void __restore_processor_state(struct saved_context *ctxt)
Index: linux-2.6.28-rc5-bkpt-latest/arch/x86/power/cpu_64.c
===================================================================
--- linux-2.6.28-rc5-bkpt-latest.orig/arch/x86/power/cpu_64.c
+++ linux-2.6.28-rc5-bkpt-latest/arch/x86/power/cpu_64.c
@@ -15,6 +15,7 @@
#include <asm/pgtable.h>
#include <asm/mtrr.h>
#include <asm/xcr.h>
+#include <asm/debugreg.h>
static void fix_processor_context(void);
@@ -70,6 +71,7 @@ static void __save_processor_state(struc
ctxt->cr3 = read_cr3();
ctxt->cr4 = read_cr4();
ctxt->cr8 = read_cr8();
+ disable_debug_registers();
}
void save_processor_state(void)
@@ -158,16 +160,5 @@ static void fix_processor_context(void)
load_TR_desc(); /* This does ltr */
load_LDT(¤t->active_mm->context); /* This does lldt */
- /*
- * Now maybe reload the debug registers
- */
- if (current->thread.debugreg7){
- loaddebug(¤t->thread, 0);
- loaddebug(¤t->thread, 1);
- loaddebug(¤t->thread, 2);
- loaddebug(¤t->thread, 3);
- /* no 4 and 5 */
- loaddebug(¤t->thread, 6);
- loaddebug(¤t->thread, 7);
- }
+ load_debug_registers();
}
Index: linux-2.6.28-rc5-bkpt-latest/arch/x86/kernel/smpboot.c
===================================================================
--- linux-2.6.28-rc5-bkpt-latest.orig/arch/x86/kernel/smpboot.c
+++ linux-2.6.28-rc5-bkpt-latest/arch/x86/kernel/smpboot.c
@@ -62,6 +62,7 @@
#include <asm/mtrr.h>
#include <asm/vmi.h>
#include <asm/genapic.h>
+#include <asm/debugreg.h>
#include <linux/mc146818rtc.h>
#include <mach_apic.h>
@@ -350,6 +351,7 @@ static void __cpuinit start_secondary(vo
setup_secondary_clock();
wmb();
+ load_debug_registers();
cpu_idle();
}
@@ -1356,6 +1358,7 @@ void cpu_disable_common(void)
remove_cpu_from_maps(cpu);
unlock_vector_lock();
fixup_irqs(cpu_online_map);
+ disable_debug_registers();
}
int native_cpu_disable(void)
next prev parent reply other threads:[~2008-12-04 19:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 19:08 [RFC Patch 0/9] Hardware Breakpoint interfaces - v2 K.Prasad
2008-12-04 19:11 ` [RFC Patch 1/9] Introducing generic hardware breakpoint handler interfaces K.Prasad
2008-12-04 19:38 ` David Daney
2008-12-17 3:47 ` K.Prasad
2008-12-04 19:11 ` [RFC Patch 2/9] x86 architecture implementation of Hardware Breakpoint interfaces K.Prasad
2008-12-04 19:12 ` [RFC Patch 3/9] Modifying generic debug exception to use virtual debug registers K.Prasad
2008-12-04 19:13 ` [RFC Patch 4/9] Modify kprobe exception handler to recognise single-stepping by HW Breakpoint handler K.Prasad
2008-12-04 19:13 ` K.Prasad [this message]
2008-12-04 19:13 ` [RFC Patch 6/9] Use virtual debug registers in process/thread handling code K.Prasad
2008-12-04 19:14 ` [RFC Patch 7/9] Modify signal handling code to refrain from re-enabling HW Breakpoints K.Prasad
2008-12-04 19:16 ` [RFC Patch 8/9] Modify Ptrace routines to access breakpoint registers K.Prasad
2008-12-04 19:17 ` [RFC Patch 9/9] Cleanup HW Breakpoint registers before kexec K.Prasad
2008-12-04 19:17 ` [RFC Patch 0/9] Hardware Breakpoint interfaces - v2 K.Prasad
-- strict thread matches above, loose matches on Subject: below --
2008-10-08 19:20 K.Prasad
2008-10-08 19:25 ` [RFC Patch 5/9] Use wrapper routines around debug registers in processor related functions K.Prasad
2008-10-07 11:38 [RFC Patch 0/9] Hardware Breakpoint interfaces K.Prasad
2008-10-07 11:44 ` [RFC Patch 5/9] Use wrapper routines around debug registers in processor related functions K.Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204191325.GE20563@in.ibm.com \
--to=prasad@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=richardj_moore@uk.ibm.com \
--cc=roland@redhat.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox