public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Luca Santarelli <hrk@users.sourceforge.net>
To: marcel@holtmann.org
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] bluetooth usb hci: ISSC usb dongle with buggy SCO support
Date: Fri, 5 Dec 2008 00:02:13 +0100	[thread overview]
Message-ID: <200812050002.13560.hrk@users.sourceforge.net> (raw)

From: Luca Santarelli <hrk <t> users.sourceforge.net>

As reported at:
http://bugs.gentoo.org/show_bug.cgi?id=249523
and in reference of similar patches such as:
http://thread.gmane.org/gmane.linux.bluez.devel/15067

This patch changes the blacklist entry for the ISSC bluetooth USB
dongle fixing the issue of the repeatedly appearing message

  hci_scodata_packet: hci0 SCO packet for unknown connection handle 92

in the kernel logs.

Sighed-off-by: Luca Santarelli <hrk <at> users.sourceforge.net>
---
This is my first kernel patch ever, I read the docs, but please notify
me if I made any mistake. Thank you all for your work, I'm happy to have
been able to contribute to this!

The patch has been run against 2.6.27.7 and has been tested on three x86
machines, showing no issues. In my own tests, the dongle has been then
used to connect to devices and everything worked fine.

--- linux-2.6.27.7/drivers/bluetooth/hci_usb.c.orig	2008-12-04 20:18:38.000000000 +0100
+++ linux-2.6.27.7/drivers/bluetooth/hci_usb.c	2008-12-04 20:19:37.000000000 +0100
@@ -148,8 +148,8 @@ static struct usb_device_id blacklist_id
 	{ USB_DEVICE(0x047d, 0x105d), .driver_info = HCI_RESET },
 	{ USB_DEVICE(0x047d, 0x105e), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
 
-	/* ISSC Bluetooth Adapter v3.1 */
-	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET },
+	/* ISSC Bluetooth Adapter v3.1 with buggy SCO support */
+	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET | HCI_BROKEN_ISOC },
 
 	/* RTX Telecom based adapters with buggy SCO support */
 	{ USB_DEVICE(0x0400, 0x0807), .driver_info = HCI_BROKEN_ISOC },

             reply	other threads:[~2008-12-04 23:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04 23:02 Luca Santarelli [this message]
2008-12-07  8:19 ` [PATCH] bluetooth usb hci: ISSC usb dongle with buggy SCO support Andrew Morton
2008-12-07 12:58   ` Daniel Drake
2008-12-08 23:07   ` Luca Santarelli
2008-12-09 13:49     ` Markos Chandras
2008-12-09 19:22     ` Luca Santarelli
2008-12-09 12:31   ` Markos Chandras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812050002.13560.hrk@users.sourceforge.net \
    --to=hrk@users.sourceforge.net \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox