From: Nick Andrew <nick@nick-andrew.net>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Matt Mackall <mpm@selenic.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Use vprintk rather that vsnprintf where possible
Date: Fri, 5 Dec 2008 14:13:12 +1100 [thread overview]
Message-ID: <20081205031312.GA1381@mail.local.tull.net> (raw)
In-Reply-To: <ac3eb2510812041905j639ea7d4ybe8e83b0d7c5965e@mail.gmail.com>
On Fri, Dec 05, 2008 at 04:05:06AM +0100, Kay Sievers wrote:
> On Thu, Dec 4, 2008 at 21:41, Matt Mackall <mpm@selenic.com> wrote:
> > This does away with lots of large static and on-stack buffers as well
> > as a few associated locks.
>
> > - len = snprintf(s, 256, KERN_DEBUG "%s: ", prefix);
> > -
> > va_start(args, fmt);
> > - len += vsnprintf(&s[len], (256 - len), fmt, args);
> > + printk(KERN_DEBUG "%s: ", prefix);
> > + vprintk(fmt, args);
>
> If we convert to two printk calls for a single line, does that not
> possibly get mixed up with printks from other locations and lead to
> hardly readable log output?
That's right.
Nick.
next prev parent reply other threads:[~2008-12-05 3:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 20:41 [PATCH] Use vprintk rather that vsnprintf where possible Matt Mackall
2008-12-05 3:05 ` Kay Sievers
2008-12-05 3:13 ` Nick Andrew [this message]
2008-12-05 4:08 ` Matt Mackall
2008-12-05 4:21 ` Joe Perches
2008-12-05 13:49 ` Tilman Schmidt
2008-12-07 8:05 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081205031312.GA1381@mail.local.tull.net \
--to=nick@nick-andrew.net \
--cc=akpm@linux-foundation.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox