Re: [PATCH] Use vprintk rather that vsnprintf where possible

Andrew Morton
2008-12-07T08:06:19Z

On Thu, 04 Dec 2008 14:41:49 -0600 Matt Mackall <mpm@selenic.com> wrote:

>
> This does away with lots of large static and on-stack buffers as well
> as a few associated locks.

Please add diffstats to the patches.

drivers/cpufreq/cpufreq.c | 11 +------
drivers/scsi/arm/fas216.c | 6 +---
drivers/scsi/nsp32.c | 25 +++++++----------
drivers/scsi/pcmcia/nsp_cs.c | 24 +++++++---------
fs/adfs/super.c | 12 +++-----
fs/affs/amigaffs.c | 22 ++++++---------
fs/befs/debug.c | 47 ++++++---------------------------
fs/hpfs/super.c | 7 +---
fs/jfs/super.c | 7 ++--
fs/ntfs/debug.c | 46 ++++++++++++--------------------
fs/ocfs2/super.c | 22 +++++++--------
fs/partitions/ldm.c | 7 ++--
fs/udf/super.c | 16 +++++------
fs/ufs/super.c | 46 ++++++++++++++++----------------
fs/xfs/support/debug.c | 26 ++++--------------
15 files changed, 121 insertions(+), 203 deletions(-)

argh. I count at least thirteen separate developers who need to review
this patch. Many of them would ideally be the ones who merge their
piece of it. If they have issues or request updates, that churns the
whole patch.

I think I'll skip this one.

Overall it looks sensible (better than what we have now). But
maintainers are funny things. Parts of it will survive, others won't.