From: Greg KH <gregkh@suse.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Alexander Beregalov <a.beregalov@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: convert to list_for_each()
Date: Sat, 6 Dec 2008 17:10:37 -0800 [thread overview]
Message-ID: <20081207011037.GA16462@suse.de> (raw)
In-Reply-To: <20081206203740.GA2264@x200.localdomain>
On Sat, Dec 06, 2008 at 11:37:40PM +0300, Alexey Dobriyan wrote:
> On Sat, Dec 06, 2008 at 09:49:05PM +0300, Alexander Beregalov wrote:
>
> No, switch to list_for_each_entry() from the very beginning.
I agree, please use list_for_each_entry() instead.
Also, if you could split this up into two patches? One for each driver
would be apprecited.
thanks,
greg k-h
prev parent reply other threads:[~2008-12-07 1:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-06 18:49 [PATCH] Staging: convert to list_for_each() Alexander Beregalov
2008-12-06 20:37 ` Alexey Dobriyan
2008-12-07 1:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081207011037.GA16462@suse.de \
--to=gregkh@suse.de \
--cc=a.beregalov@gmail.com \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox