Re: Device loses barrier support (was: Fixed patch for simple barriers.)

Dave Chinner
2008-12-07T04:17:24Z

On Thu, Dec 04, 2008 at 11:45:44AM -0500, Mikulas Patocka wrote:
> > The write block with barrier bit varies, jbd/gfs2 do it synchronously
> > too and xfs does it asynchronously (with io done callbacks), but
>
> And how does xfs preserve write ordering, if the barrier asynchronously
> fails with -EOPNOTSUPP and there are other writes submitted after the
> barrier?

Doesn't matter. XFS executes journal state changes during the I/O
completion callbacks a layer above this resubmit code. Hence,
if the I/O is resubmitted before the completion callbacks are
run, it just appears that the I/O has taken longer than expected
and the state change is delayed....

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com