From: Johannes Weiner <hannes@cmpxchg.org>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [Patch] uml: drop const qualifier for kernel_execve()
Date: Sun, 7 Dec 2008 20:55:38 +0100 [thread overview]
Message-ID: <20081207195537.GA24808@cmpxchg.org> (raw)
In-Reply-To: <2375c9f90812051702m217ee049i79ce2f9cc8280fb1@mail.gmail.com>
On Sat, Dec 06, 2008 at 01:02:16AM +0000, Américo Wang wrote:
> On Wed, Dec 3, 2008 at 1:40 PM, Johannes Weiner <hannes@cmpxchg.org> wrote:
> > On Wed, Dec 03, 2008 at 12:32:02PM +0000, Américo Wang wrote:
> >> On Wed, Dec 3, 2008 at 1:20 AM, Johannes Weiner <hannes@cmpxchg.org> wrote:
> >> > On Tue, Dec 02, 2008 at 10:51:09PM +0000, Américo Wang wrote:
> >> >> UML implementation of kernel_execve() should not have const qualifier,
> >> >> because it will finally call do_execve() which doesn't have.
> >> >
> >> > And you made sure that do_execve() is correctly annotated?
> >> >
> >>
> >> Yes, I checked that.
> >
> > Good. Then please fix up do_execve() or let the warning stand out as
> > a reminder.
>
> ??
> Confused...
>
> do_execve() is OK, we don't need to fix it.
I don't see where it writes through @filename. So it seems the right
fix would be to make do_execve()s parameter const (and as it seems, a
lot more adjustments down this call graph) and not remove a correct
const from a callsite.
Hannes
next prev parent reply other threads:[~2008-12-07 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 22:51 [Patch] uml: drop const qualifier for kernel_execve() Américo Wang
2008-12-03 1:20 ` Johannes Weiner
2008-12-03 12:32 ` Américo Wang
2008-12-03 13:40 ` Johannes Weiner
2008-12-06 1:02 ` Américo Wang
2008-12-07 19:55 ` Johannes Weiner [this message]
2008-12-26 9:32 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081207195537.GA24808@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox