From: Andrew Morton <akpm@linux-foundation.org>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mike Travis <travis@sgi.com>,
"David S. Miller" <davem@davemloft.net>,
linux kernel <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux-foundation.org>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH, take2] percpu_counter: FBC_BATCH might be too big
Date: Sun, 7 Dec 2008 20:32:44 -0800 [thread overview]
Message-ID: <20081207203244.10372834.akpm@linux-foundation.org> (raw)
In-Reply-To: <493C1632.2000901@cosmosbay.com>
On Sun, 07 Dec 2008 19:30:10 +0100 Eric Dumazet <dada1@cosmosbay.com> wrote:
> >
> > Do
> >
> > $EDITOR $(grep -l hotcpu_notifier */*.c)
> >
> > and you'll see lots of code gets it right, and lots of code gets it wrong.
>
> I see nothing interesting, I must be blind.
>
> lib/percpu_counter.c: In function 'percpu_counter_startup':
> lib/percpu_counter.c:158: error: 'percpu_counter_hotcpu_callback' undeclared (first use in this function)
> lib/percpu_counter.c:158: error: (Each undeclared identifier is reported only once
> lib/percpu_counter.c:158: error: for each function it appears in.)
> make[1]: *** [lib/percpu_counter.o] Error 1
Perhaps you still had percpu_counter_hotcpu_callback inside #ifdef.
That a look at kernel/workqueue.c, fs/buffer.c. No #ifdef CONFIG_HOTPLUG_CPU
needed at all.
next prev parent reply other threads:[~2008-12-08 4:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 16:05 [PATCH] percpu_counter: FBC_BATCH might be too big Eric Dumazet
2008-12-05 16:40 ` Peter Zijlstra
2008-12-05 20:32 ` David Miller
2008-12-07 9:25 ` [PATCH, take2] " Eric Dumazet
2008-12-07 17:09 ` Andrew Morton
2008-12-07 18:30 ` Eric Dumazet
2008-12-08 4:32 ` Andrew Morton [this message]
2008-12-08 8:05 ` [PATCH] percpu_counter: FBC_BATCH should be a variable Eric Dumazet
2008-12-08 8:19 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081207203244.10372834.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=cl@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox