From: Evgeniy Polyakov <zbr@ioremap.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, frederik.deweerdt@xprog.eu,
randy.dunlap@oracle.com
Subject: Re: [W1] List slaves commands.
Date: Tue, 9 Dec 2008 01:49:58 +0300 [thread overview]
Message-ID: <20081208224958.GA29032@ioremap.net> (raw)
In-Reply-To: <20081208135848.2a529f86.akpm@linux-foundation.org>
On Mon, Dec 08, 2008 at 01:58:48PM -0800, Andrew Morton (akpm@linux-foundation.org) wrote:
> This code performs quite a lot of potentially unaligned acceses.
>
> Is there anything which guarantees that all these accesses are
> well-aligned?
>
> If not, will there be issues with platforms which don't handle
> unaligned accesses as well as x86?
>
> Should this code be using the unaligned access interfaces
> (get_unaligned, put_unaligned, etc. Might be wrong. Keeps changing.
> Harvey Harrison is the guy to ask)?
Every store should be at least 4-bytes aligned because of used headers.
Particular mentioned command is 8-bytes aligned (and all its writes)
as long as others in this patchset (pointer alignment + 40 or 32 bytes
of the headers).
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-12-08 22:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 12:41 [W1 take2]: extend userspace commands Evgeniy Polyakov
2008-12-05 12:41 ` [W1] Added list masters w1 command Evgeniy Polyakov
2008-12-05 12:41 ` [W1] Added touch block command Evgeniy Polyakov
2008-12-05 12:41 ` [W1] List slaves commands Evgeniy Polyakov
2008-12-05 12:41 ` [W1] Documentation update Evgeniy Polyakov
2008-12-08 21:58 ` [W1] List slaves commands Andrew Morton
2008-12-08 22:49 ` Evgeniy Polyakov [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-04 14:50 [W1] extend userspace commands Evgeniy Polyakov
2008-12-04 14:50 ` Evgeniy Polyakov
2008-12-04 14:50 ` [W1] Added list masters w1 command Evgeniy Polyakov
2008-12-04 14:50 ` [W1] Added touch block command Evgeniy Polyakov
2008-12-04 14:50 ` [W1] Updated documentation Evgeniy Polyakov
2008-12-04 14:50 ` [W1] List slaves commands Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081208224958.GA29032@ioremap.net \
--to=zbr@ioremap.net \
--cc=akpm@linux-foundation.org \
--cc=frederik.deweerdt@xprog.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox